Issue 3531 in pharo: [FIX]ParseNodeEnumerator does not visits ivar nodes

Status: Fixed
Owner: siguctua
CC: stephane.ducasse,  marcus.denker,  eliot.miranda
Labels: Milestone-1.2

New issue 3531 by siguctua: [FIX]ParseNodeEnumerator does not visits ivar  
nodes
http://code.google.com/p/pharo/issues/detail?id=3531

i found that enumerator does not does not visits the instance variable node:

visitInstanceVariableNode: anInstanceVariableNode
        (self shouldVisit: anInstanceVariableNode) ifFalse:
                [^nil].
"       theBlock value: anInstanceVariableNode.   <<<< missing "
        ^super visitInstanceVariableNode: anInstanceVariableNode

I thought that it was left on purpose, but Eliot confirmed that its a bug.
The fix is in attachment.

Attachments:
        CompilerParser-class-fix.1.cs  408 bytes

Comment #1 on issue 3531 by nicolas.cellier.aka.nice:  
[FIX]ParseNodeEnumerator does not visits ivar nodes
http://code.google.com/p/pharo/issues/detail?id=3531

Hi Igor, sounds like the wrong .cs

Comment #2 on issue 3531 by siguctua: [FIX]ParseNodeEnumerator does not  
visits ivar nodes
http://code.google.com/p/pharo/issues/detail?id=3531

- added right changeset

Attachments:
        ParseNodeEnumerator-fix-ivar-visiting.1.cs  902 bytes

Updates:
        Status: Closed

Comment #3 on issue 3531 by marcus.denker: [FIX]ParseNodeEnumerator does  
not visits ivar nodes
http://code.google.com/p/pharo/issues/detail?id=3531

12296