Issue 3542 in pharo: Add SmalltalkImage>>#gcBiasToGrow: and friends to core

Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.2

New issue 3542 by [hidden email]: Add SmalltalkImage>>#gcBiasToGrow:  
and friends to core
http://code.google.com/p/pharo/issues/detail?id=3542

These methods were added through the dev image, but obviously should also  
be present in a deployment configuration.

I also added initializeMemorySettingsProfileSeaside, which should give a  
better GC behavior for Seaside apps.

Attachments:
        gcbiastogrow.2.cs  6.7 KB

Updates:
        Status: Closed

Comment #1 on issue 3542 by [hidden email]: Add  
SmalltalkImage>>#gcBiasToGrow: and friends to core
http://code.google.com/p/pharo/issues/detail?id=3542

in 12307

Updates:
        Cc: stephane.ducasse

Comment #2 on issue 3542 by [hidden email]: Add  
SmalltalkImage>>#gcBiasToGrow: and friends to core
http://code.google.com/p/pharo/issues/detail?id=3542

So #12307 also adds #initializeMemorySettingsProfileSeaside
to the core image? Why?

Seaside is important, but I would like to see this in one of the
"Seaside-Pharo" packages on the seaside, not in the core pharo
image.

Otherwise we will end up with
   #initializeMemorySettingsProfileMoose
   #initializeMemorySettingsProfileGlamour
   #initializeMemorySettingsProfileMyFavouriteApp
   ...

Or is it just the name? And we should name it
initializeMemorySettingsProfileForMostUseCases ;)

Also take care: the changeset was from "Pharo-1.1-11411" and has  
recategorizations in it. Dont know if this has side effects on already  
recategorized/repackaged methods in SmalltalkImage.

Updates:
        Status: Comment

Comment #3 on issue 3542 by [hidden email]: Add  
SmalltalkImage>>#gcBiasToGrow: and friends to core
http://code.google.com/p/pharo/issues/detail?id=3542

Thanks for the review, Torsten. Those are valid concerns. We can leave out  
#initializeMemorySettingsProfileSeaside and suggest to the Seaside folks to  
add this method as an extension. I included it in the changeset because in  
the Pharo-dev image it doesn't make sense as many people probably deploy  
with PharoCore. The important part of the change is to have #gcBiasToGrow:  
in core.

Also, we should remove the moved methods from  
http://www.squeaksource.com/ImageForDevelopers.html. Is somebody actively  
maintaining this package?

Updates:
        Cc: marianopeck renggli

Comment #4 on issue 3542 by [hidden email]: Add  
SmalltalkImage>>#gcBiasToGrow: and friends to core
http://code.google.com/p/pharo/issues/detail?id=3542

Added Mariano and Lukas to this issue,
Mariano seems to have most commits on ImageForDevelopers and
Lukas may be able to tell us where #initializeMemorySettingsProfileSeaside
is best integrated into Seaside.

Thanks in advance!

Comment #5 on issue 3542 by [hidden email]: Add  
SmalltalkImage>>#gcBiasToGrow: and friends to core
http://code.google.com/p/pharo/issues/detail?id=3542

Here is the cs to remove initializeMemorySettingsProfileSeaside from core.

Attachments:
        RemoveSeasideMemorySettings.1.cs  170 bytes

Comment #6 on issue 3542 by [hidden email]: Add  
SmalltalkImage>>#gcBiasToGrow: and friends to core
http://code.google.com/p/pharo/issues/detail?id=3542

Opened a seaside issue here
http://code.google.com/p/seaside/issues/detail?id=633

Updates:
        Status: Fixed

Comment #7 on issue 3542 by [hidden email]: Add  
SmalltalkImage>>#gcBiasToGrow: and friends to core
http://code.google.com/p/pharo/issues/detail?id=3542

(No comment was entered for this change.)

Comment #8 on issue 3542 by [hidden email]: Add  
SmalltalkImage>>#gcBiasToGrow: and friends to core
http://code.google.com/p/pharo/issues/detail?id=3542

I created a Seaside issue for this:
http://code.google.com/p/seaside/issues/detail?id=634
Does anybody know whether these settings are also valid for Cog?

Updates:
        Status: Closed

Comment #9 on issue 3542 by [hidden email]: Add  
SmalltalkImage>>#gcBiasToGrow: and friends to core
http://code.google.com/p/pharo/issues/detail?id=3542

12309

Comment #10 on issue 3542 by marianopeck: Add  
SmalltalkImage>>#gcBiasToGrow: and friends to core
http://code.google.com/p/pharo/issues/detail?id=3542

Hi Torsten, I am not sure what I need to commit in ImageForDevelopers. Do I  
need to remove gcBiasToGrow: since now is already in the core and I guess  
otherwise a package may be dirty?   Anyway, feel free to commit to  
ImageForDevelopers directly.

Updates:
        Cc: philippe.marschall

Comment #11 on issue 3542 by [hidden email]: Add  
SmalltalkImage>>#gcBiasToGrow: and friends to core
http://code.google.com/p/pharo/issues/detail?id=3542

Until now we should keep #initializeMemorySettingsProfileSeaside in  
ImageForDevelopers until this method is added in a new Seaside release (in  
a "Seaside-Pharo" package)

(so we wait until the seaside issue  
http://code.google.com/p/seaside/issues/detail?id=634 is fixed).

If we have that we can switch to this new seaside relase and remove the  
method from ImageForDevelopers

Comment #12 on issue 3542 by [hidden email]: Add  
SmalltalkImage>>#gcBiasToGrow: and friends to core
http://code.google.com/p/pharo/issues/detail?id=3542

Mariano, we have added the methods to PharoCore:
- gcBiasToGrow: aBool
- gcBiasToGrowLimit: arg
- primitiveGCBiasToGrow: arg

So you can remove them from ImageForDevelopers. Thanks!

Updates:
        Cc: guillermopolito

Comment #13 on issue 3542 by marianopeck: Add  
SmalltalkImage>>#gcBiasToGrow: and friends to core
http://code.google.com/p/pharo/issues/detail?id=3542

Name: ImageForDevelopers-pharo-MarianoMartinezPeck.246
Author: MarianoMartinezPeck
Time: 18 January 2011, 7:42:05 pm
UUID: c782e348-5222-496e-99bf-031a09811cef
Ancestors: ImageForDevelopers-pharo-GuillermoPolito.245

We removed the methods:
#gcBiasToGrow:
#gcBiasToGrowLimit:
#primitiveGCBiasToGrow:

 From PharoDev since they are not integrated in PharoCore1.2-12309

Fix to issue 3542

Comment #14 on issue 3542 by [hidden email]: Add  
SmalltalkImage>>#gcBiasToGrow: and friends to core
http://code.google.com/p/pharo/issues/detail?id=3542

Has been integrated into Seaside.

Comment #15 on issue 3542 by [hidden email]: Add  
SmalltalkImage>>#gcBiasToGrow: and friends to core
http://code.google.com/p/pharo/issues/detail?id=3542

So the Seaside side is fixed in Seaside-Pharo-Core-pmm.10
Phillipe: Is this already integrated in a ConfigurationOfSeasideXX...
           that one can reference?.

Mariano: time to remove #initializeMemorySettingsProfileSeaSide from
          ImageForDevelopers. Are you able to do it?

Comment #16 on issue 3542 by marianopeck: Add  
SmalltalkImage>>#gcBiasToGrow: and friends to core
http://code.google.com/p/pharo/issues/detail?id=3542

Name: ImageForDevelopers-pharo-MarianoMartinezPeck.247
Author: MarianoMartinezPeck
Time: 20 January 2011, 2:35:17 pm
UUID: e80d6e23-058e-4065-9228-123eb234d62a
Ancestors: ImageForDevelopers-pharo-MarianoMartinezPeck.246

Removed #initializeMemorySettingsProfileSeaSide
because it was integrated in latest Seaside.

Fix to issue: http://code.google.com/p/pharo/issues/detail?id=3542

Comment #17 on issue 3542 by [hidden email]: Add  
SmalltalkImage>>#gcBiasToGrow: and friends to core
http://code.google.com/p/pharo/issues/detail?id=3542

It should be in ConfigurationOfSeaside30 if you do #loadLatestVersion

Comment #18 on issue 3542 by [hidden email]: Add  
SmalltalkImage>>#gcBiasToGrow: and friends to core
http://code.google.com/p/pharo/issues/detail?id=3542

Mariano: ImageForDevelopers is used in the build for the upcoming Pharo  
1.2, isnt it?

Phillipe: is #loadLatestVersion of Seaside 3.0 working/compatible with the  
upcoming Pharo 1.2 already?

Comment #19 on issue 3542 by [hidden email]: Add  
SmalltalkImage>>#gcBiasToGrow: and friends to core
http://code.google.com/p/pharo/issues/detail?id=3542

Maybe. We didn't test it. The last time I checked OB didn't work.