Issue 355 in glassdb: unexpected semantics of #doTransaction: with multithreading (used in WAGemStoneServiceTask)

Status: Accepted
Owner: [hidden email]
Labels: Type-Defect Priority-Medium GLASS-Server Version-GLASS0.231

New issue 355 by [hidden email]: unexpected semantics of  
#doTransaction: with multithreading (used in WAGemStoneServiceTask)
http://code.google.com/p/glassdb/issues/detail?id=355

Johan reports a bug against GRGemStonePlatform>>doTransaction: (see  
http://forum.world.st/unexpected-semantics-of-doTransaction-with-multithreading-used-in-WAGemStoneServiceTask-tp4669267.html).

His suggested fix is correct ...

Comment #1 on issue 355 by [hidden email]: unexpected semantics of  
#doTransaction: with multithreading (used in WAGemStoneServiceTask)
http://code.google.com/p/glassdb/issues/detail?id=355

Noticed a typo in my previous email. This is it:

        self transactionMutex critical: [
                "Get the transactionMutex, and perform the transaction."
                System inTransaction
                        ifTrue: [ "We already are in a transaction, so just evaluate the block"
                                        aBlock value.
                                        ^ true]
                        ifFalse:[
                                        [
                                                self doBeginTransaction.
                                                aBlock value
                                        ] ensure: [ ^self doCommitTransaction]]]

Comment #2 on issue 355 by [hidden email]: unexpected semantics of  
#doTransaction: with multithreading (used in WAGemStoneServiceTask)
http://code.google.com/p/glassdb/issues/detail?id=355

Just a little not to say that since we put this fix into production, we  
have no problems whatsoever with 'blocking' service vms (which is what  
happened when our transactions got mixed up due to this error).

We're running a smooth service, so it should be good to include in a next  
version of GLASS :-)

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

Comment #3 on issue 355 by [hidden email]: unexpected semantics of  
#doTransaction: with multithreading (used in WAGemStoneServiceTask)
http://code.google.com/p/glassdb/issues/detail?id=355

committed this in  
https://github.com/glassdb/Grease/commit/de396c9ec1d3fcebabde70d11ea21346f234e6e5

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

Updates:
        Status: Fixed

Comment #4 on issue 355 by [hidden email]: unexpected semantics of  
#doTransaction: with multithreading (used in WAGemStoneServiceTask)
http://code.google.com/p/glassdb/issues/detail?id=355

mark as fixed

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings