Issue 3550 in pharo: MenuItemMorph>>mouseDown: has unnecessary check

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 3550 in pharo: MenuItemMorph>>mouseDown: has unnecessary check

pharo
Status: New
Owner: ----

New issue 3550 by [hidden email]: MenuItemMorph>>mouseDown: has  
unnecessary check
http://code.google.com/p/pharo/issues/detail?id=3550

Pharo1.2rc1 Latest update: #12310

If a menu item is clicked while it's pinned-down menu is obscured, the  
following code brings the menu to the front without executing the item's  
command:

        "Quick hack to bring menu to the front if it is obscured. See
                http://bugs.squeak.org/view.php?id=1780" "fixed by gvc to work with  
embedded menus"
" self owner owner = self world ifTrue: [
                self world morphsInFrontOf: self owner overlapping: self owner bounds
                        do: [:ignored | ^ self owner comeToFront]]."

However, in 1.2, it does not seem that a pinned-down menu /can/ be obscured  
- it magically stays on top.  So this check seems redundant.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3550 in pharo: MenuItemMorph>>mouseDown: has unnecessary check

pharo

Comment #1 on issue 3550 by [hidden email]:  
MenuItemMorph>>mouseDown: has unnecessary check
http://code.google.com/p/pharo/issues/detail?id=3550

Fix in inbox:  
SLICE-Issue-3550-MenuItemMorphmouseDown-has-unnecessary-check-SeanDeNigris.1


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3550 in pharo: MenuItemMorph>>mouseDown: has unnecessary check

pharo
Updates:
        Status: Fixed
        Labels: Milestone-1.3

Comment #2 on issue 3550 by [hidden email]:  
MenuItemMorph>>mouseDown: has unnecessary check
http://code.google.com/p/pharo/issues/detail?id=3550

(No comment was entered for this change.)


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3550 in pharo: MenuItemMorph>>mouseDown: has unnecessary check

pharo
Updates:
        Status: Closed

Comment #3 on issue 3550 by [hidden email]:  
MenuItemMorph>>mouseDown: has unnecessary check
http://code.google.com/p/pharo/issues/detail?id=3550

13004