Issue 3587 in pharo: Clean up handling of WideStrings

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 3587 in pharo: Clean up handling of WideStrings

pharo
Status: New
Owner: ----

New issue 3587 by [hidden email]: Clean up handling of WideStrings
http://code.google.com/p/pharo/issues/detail?id=3587

Code in various places in the system query #isWideString followed by an  
ifTrue:ifFalse:

The Smalltalk way would be to issue a command to the String, which is  
overridden in the wide subclasses.

Attached is a changeset that makes some of these changes.

All Collections and Morphic tests green in Pharo1.2rc1 Latest update: #12320

Attachments:
        Wide String cleanup.3.cs  6.1 KB


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3587 in pharo: Clean up handling of WideStrings

pharo
Updates:
        Status: FixProposed

Comment #1 on issue 3587 by [hidden email]: Clean up handling of  
WideStrings
http://code.google.com/p/pharo/issues/detail?id=3587

(No comment was entered for this change.)


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3587 in pharo: Clean up handling of WideStrings

pharo
Updates:
        Labels: Milestone-1.3

Comment #2 on issue 3587 by [hidden email]: Clean up handling of  
WideStrings
http://code.google.com/p/pharo/issues/detail?id=3587

Igor says we need to check if the VMmaker does not require the primitive to  
be in a certain class. (bytestring)

Else good.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3587 in pharo: Clean up handling of WideStrings

pharo
Updates:
        Status: Started

Comment #3 on issue 3587 by [hidden email]: Clean up handling of  
WideStrings
http://code.google.com/p/pharo/issues/detail?id=3587

(No comment was entered for this change.)


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3587 in pharo: Clean up handling of WideStrings

pharo
Updates:
        Labels: -Milestone-1.3

Comment #4 on issue 3587 by [hidden email]: Clean up handling of  
WideStrings
http://code.google.com/p/pharo/issues/detail?id=3587

(No comment was entered for this change.)