Issue 3603 in pharo: O/ECompletion failure in Trait methods

Status: Accepted
Owner: [hidden email]
CC: [hidden email]
Labels: Milestone-1.2-DevImage Milestone-1.3-DevImage OCompletion

New issue 3603 by [hidden email]: O/ECompletion failure in Trait methods
http://code.google.com/p/pharo/issues/detail?id=3603

A debugger pops up when typing in after super in a trait method, since  
traits do not implement superclass.
Reproduction steps at:
http://screencast.com/t/yyjLLm0S

Mailing list thread:
http://forum.world.st/First-commit-to-Pharoinbox-Need-advice-tp3237535p3241521.html

On Thu, 27 Jan 2011, [hidden email] wrote:

The bug is not related to OCompletion. Traits implement (via
TPureBehavior) #allSuperclasses, #withAllSuperclasses, etc., but lack
#superclass. Also note that these methods are not in sync with their
comments. Btw it's a bit strange (but acceptable) that Traits are not
Behaviors.


Levente

> Reproduction steps at:
> http://screencast.com/t/yyjLLm0S
>
> Mailing list thread:
> http://forum.world.st/First-commit-to-Pharoinbox-Need-advice-tp3237535p3241521.html
>
>

On 27.01.2011 19:53, Levente Uzonyi wrote: So which implementation of #superclass would you recommend for Trait,
which would keep O/ECompletion working without modification?
I can't think of any which makes sense really.

IMO, if code in the component eventually needs to be changed to not
raise a debugger, it's related.

Cheers,
Henry

On Thu, 27 Jan 2011, Henrik Sperre Johansen wrote:

nil is a possiblity or remove the super- and subclass related methods, see
below.

>
> IMO, if code in the component eventually needs to be changed to not raise a
> debugger, it's related.

We could ignore the errors, but hiding bugs is a bad idea IMHO. We can add
a check too, but what can you say about the following anomalies in the
trait implementation?

| justATrait |
justATrait := TPureBehavior.
justATrait isTrait. "true ok"
justATrait isBehavior. "false strange"
justATrait allSuperclasses. "an OrderedCollection() ok if there should be none"
justATrait withAllSuperclasses. "an OrderedCollection(TPureBehavior) ok, but the comment says it should contain Object too"
justATrait subclasses. " #() acceptable"
justATrait superclass. "Error WTF?"


Btw, what happened to the clipboard in Pharo 1.2 on windows? If I copy
text, the line endings are CRs, not CRLFs, so the text is a single line.


Levente

>

On Thu, 27 Jan 2011, Henrik Sperre Johansen wrote:

Okay, I added a check for this. It's in Ocompletion-ul.91.


Levente

>
> Cheers,
> Henry
>
>

Updates:
        Labels: -Milestone-1.3-DevImage

Comment #1 on issue 3603 by [hidden email]: O/ECompletion failure in  
Trait methods
http://code.google.com/p/pharo/issues/detail?id=3603

(No comment was entered for this change.)

Comment #2 on issue 3603 by [hidden email]: O/ECompletion failure in  
Trait methods
http://code.google.com/p/pharo/issues/detail?id=3603

A few fixes from Levente were integrated in the configuration of  
OCompletion.  Will load in next full build.

Updates:
        Status: Fixed

Comment #3 on issue 3603 by [hidden email]: O/ECompletion failure in  
Trait methods
http://code.google.com/p/pharo/issues/detail?id=3603

(No comment was entered for this change.)

Updates:
        Status: Closed

Comment #4 on issue 3603 by [hidden email]: O/ECompletion failure in  
Trait methods
http://code.google.com/p/pharo/issues/detail?id=3603

(No comment was entered for this change.)