Issue 3618 in pharo: logError: aString inContext: aContext to: is used and it is deprecated

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 3618 in pharo: logError: aString inContext: aContext to: is used and it is deprecated

pharo
Status: Accepted
Owner: [hidden email]
CC: [hidden email]
Labels: Milestone-1.3

New issue 3618 by [hidden email]: logError: aString inContext:  
aContext to: is used and it is deprecated
http://code.google.com/p/pharo/issues/detail?id=3618

3 notifyLabel: 'foo'


openContext: aContext label: aString contents: contentsStringOrNil

        "Open a notifier in response to an error, halt, or notify. A notifier view  
just shows a short view of the sender stack and provides a menu that lets  
the user open a full debugger."
        <primitive: 19> "Simulation guard"
        ErrorRecursion not & self logDebuggerStackToFile ifTrue:
                [Smalltalk logError: aString inContext: aContext to: 'PharoDebug.log'].
          ErrorRecursion ifTrue:[
                ErrorRecursion := false.
                self primitiveError: aString].
        ErrorRecursion := true.
        self informExistingDebugger: aContext label: aString.
        (self class context: aContext)
                openNotifierContents: contentsStringOrNil
                label: aString.
        ErrorRecursion := false.
        Processor activeProcess suspend.



Reply | Threaded
Open this post in threaded view
|

Re: Issue 3618 in pharo: logError: aString inContext: aContext to: is used and it is deprecated

pharo

Comment #1 on issue 3618 by [hidden email]: logError: aString  
inContext: aContext to: is used and it is deprecated
http://code.google.com/p/pharo/issues/detail?id=3618

Also, (self class context: aContext) should just be (self context: aContext)

Additionally, the ErrorRecursion maybe should be set before the first  
lines, I am unable to load updates due to recursion (via the deprecation)...

Perhaps this is all now horribly broken...


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3618 in pharo: logError: aString inContext: aContext to: is used and it is deprecated

pharo
Updates:
        Status: Closed

Comment #2 on issue 3618 by [hidden email]: logError: aString  
inContext: aContext to: is used and it is deprecated
http://code.google.com/p/pharo/issues/detail?id=3618

Normally we fixed that yesterday in 13025
Let us know if this is not the case


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3618 in pharo: logError: aString inContext: aContext to: is used and it is deprecated

pharo

Comment #3 on issue 3618 by [hidden email]: logError: aString  
inContext: aContext to: is used and it is deprecated
http://code.google.com/p/pharo/issues/detail?id=3618

in fact it did not make it in. So fixed in 12027 (strange).
Too many people talking around probably.