Smalltalk › Pharo › Pharo Smalltalk Developers

Issue 3620 in pharo: Settings: OCompletion settings appear twice

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 21 messages Options
12
pharo
Reply | Threaded
Open this post in threaded view
♦
♦
|

Issue 3620 in pharo: Settings: OCompletion settings appear twice

pharo
Status: Accepted
Owner: [hidden email]

New issue 3620 by [hidden email]: Settings: OCompletion settings  
appear twice
http://code.google.com/p/pharo/issues/detail?id=3620

Pharo image: dev 1.2

Steps to reproduce:
1. open settings
2. in search field type 'compl' then enter
3. OCompletion settings appear twice



pharo
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Issue 3620 in pharo: Settings: OCompletion settings appear twice

pharo

Comment #1 on issue 3620 by [hidden email]: Settings: OCompletion  
settings appear twice
http://code.google.com/p/pharo/issues/detail?id=3620

Fix (naive) here:  
SLICE-Issue-3620-Settings-OCompletion-settings-appear-twice-LaurentLaffont.1


Levente Uzonyi-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Issue 3620 in pharo: Settings: OCompletion settings appear twice

Levente Uzonyi-2
On Fri, 28 Jan 2011, [hidden email] wrote:

>
> Comment #1 on issue 3620 by [hidden email]: Settings: OCompletion
> settings appear twice
> http://code.google.com/p/pharo/issues/detail?id=3620
>
> Fix (naive) here:
> SLICE-Issue-3620-Settings-OCompletion-settings-appear-twice-LaurentLaffont.1
>
>

The actual problem is that SettingsBrowser is showing Squeak's pragma
preferences as Pharo's system settings. See SettingTreeBuilder >>
#preference:category:description:type: for the implementation.

I see three possible scenarios to resolve this issue:
1. Your fix will be accepted (which implies that OCompletion will be forked).
2. We remove ECPreferences class >> #settingsOn: from OCompletion.
3. You remove SettingTreeBuilder >> #preference:category:description:type:
from Pharo.


Levente

Alain Plantec-4
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Issue 3620 in pharo: Settings: OCompletion settings appear twice

Alain Plantec-4
Le 29/01/2011 00:16, Levente Uzonyi a écrit :

> On Fri, 28 Jan 2011, [hidden email] wrote:
>
>>
>> Comment #1 on issue 3620 by [hidden email]: Settings:
>> OCompletion settings appear twice
>> http://code.google.com/p/pharo/issues/detail?id=3620
>>
>> Fix (naive) here:
>> SLICE-Issue-3620-Settings-OCompletion-settings-appear-twice-LaurentLaffont.1
>>
>>
>
> The actual problem is that SettingsBrowser is showing Squeak's pragma
> preferences as Pharo's system settings. See SettingTreeBuilder >>
> #preference:category:description:type: for the implementation.
>
> I see three possible scenarios to resolve this issue:
> 1. Your fix will be accepted (which implies that OCompletion will be
> forked).
> 2. We remove ECPreferences class >> #settingsOn: from OCompletion.
> 3. You remove SettingTreeBuilder >>
> #preference:category:description:type: from Pharo.
4. Maybe it's also possible to remove duplicated entries (so just a UI
problem).
Cheers
Alain
>
>
> Levente
>
>


Stéphane Ducasse
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Issue 3620 in pharo: Settings: OCompletion settings appear twice

Stéphane Ducasse
In reply to this post by Levente Uzonyi-2
But why the UI collects the squeak preferences?

>> Comment #1 on issue 3620 by [hidden email]: Settings: OCompletion settings appear twice
>> http://code.google.com/p/pharo/issues/detail?id=3620
>>
>> Fix (naive) here: SLICE-Issue-3620-Settings-OCompletion-settings-appear-twice-LaurentLaffont.1
>>
>>
>
> The actual problem is that SettingsBrowser is showing Squeak's pragma preferences as Pharo's system settings. See SettingTreeBuilder >> #preference:category:description:type: for the implementation.
>
> I see three possible scenarios to resolve this issue:
> 1. Your fix will be accepted (which implies that OCompletion will be forked).
> 2. We remove ECPreferences class >> #settingsOn: from OCompletion.
> 3. You remove SettingTreeBuilder >> #preference:category:description:type: from Pharo.
>
>
> Levente
>


pharo
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Issue 3620 in pharo: Settings: OCompletion settings appear twice

pharo
In reply to this post by pharo
Updates:
        Status: FixProposed
        Labels: Milestone-1.2-DevImage

Comment #2 on issue 3620 by [hidden email]: Settings: OCompletion  
settings appear twice
http://code.google.com/p/pharo/issues/detail?id=3620

(No comment was entered for this change.)


pharo
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Issue 3620 in pharo: Settings: OCompletion settings appear twice

pharo

Comment #3 on issue 3620 by [hidden email]: Settings: OCompletion  
settings appear twice
http://code.google.com/p/pharo/issues/detail?id=3620

Only pragmas were removed.  Should I Integrate it?  I think it looks ok.


pharo
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Issue 3620 in pharo: Settings: OCompletion settings appear twice

pharo

Comment #4 on issue 3620 by [hidden email]: Settings: OCompletion  
settings appear twice
http://code.google.com/p/pharo/issues/detail?id=3620

yes


pharo
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Issue 3620 in pharo: Settings: OCompletion settings appear twice

pharo

Comment #5 on issue 3620 by [hidden email]: Settings: OCompletion  
settings appear twice
http://code.google.com/p/pharo/issues/detail?id=3620

So who commits this? me?


pharo
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Issue 3620 in pharo: Settings: OCompletion settings appear twice

pharo

Comment #6 on issue 3620 by [hidden email]: Settings: OCompletion  
settings appear twice
http://code.google.com/p/pharo/issues/detail?id=3620

No idea but it would be good to move on this front.
Guillermo who is your fuse? Esteban?


pharo
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Issue 3620 in pharo: Settings: OCompletion settings appear twice

pharo

Comment #7 on issue 3620 by [hidden email]: Settings: OCompletion  
settings appear twice
http://code.google.com/p/pharo/issues/detail?id=3620

These are OCompletion changes... I can move them into PharoTaskForces  
tonight.  Will that do it?


pharo
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Issue 3620 in pharo: Settings: OCompletion settings appear twice

pharo

Comment #8 on issue 3620 by [hidden email]: Settings: OCompletion  
settings appear twice
http://code.google.com/p/pharo/issues/detail?id=3620

Why not in the OCompletion repository?


pharo
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Issue 3620 in pharo: Settings: OCompletion settings appear twice

pharo

Comment #9 on issue 3620 by [hidden email]: Settings: OCompletion  
settings appear twice
http://code.google.com/p/pharo/issues/detail?id=3620

I don't think you'll be able to successfully push a change which would  
remove access to the preference in Squeak to the OCompletion repository.

Probably better to change the Settings Browser UI to not display settings  
defined in both ways (<systemsettings> and <preference:category:...> )twice.


pharo
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Issue 3620 in pharo: Settings: OCompletion settings appear twice

pharo

Comment #10 on issue 3620 by [hidden email]: Settings: OCompletion  
settings appear twice
http://code.google.com/p/pharo/issues/detail?id=3620

Yep, I' don't want to break squeak compatibility unless it's completely  
necessary...

I guess that if we have to change the settings pragma collector, it's not  
fixed yet :)


pharo
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Issue 3620 in pharo: Settings: OCompletion settings appear twice

pharo
Updates:
        Status: Accepted

Comment #11 on issue 3620 by [hidden email]: Settings: OCompletion  
settings appear twice
http://code.google.com/p/pharo/issues/detail?id=3620

So what is the *simplest* *easiest* workaround for this so that we can  
actually release 1.2?



pharo
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Issue 3620 in pharo: Settings: OCompletion settings appear twice

pharo

Comment #12 on issue 3620 by [hidden email]: Settings: OCompletion  
settings appear twice
http://code.google.com/p/pharo/issues/detail?id=3620

As far as I understand, there is no simple solution. Could we not leave  
with this for 1.2?


pharo
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Issue 3620 in pharo: Settings: OCompletion settings appear twice

pharo

Comment #13 on issue 3620 by [hidden email]: Settings: OCompletion  
settings appear twice
http://code.google.com/p/pharo/issues/detail?id=3620

yes.


pharo
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Issue 3620 in pharo: Settings: OCompletion settings appear twice

pharo

Comment #14 on issue 3620 by [hidden email]: Settings: OCompletion  
settings appear twice
http://code.google.com/p/pharo/issues/detail?id=3620

Levente suggests to fork it for 1.2:

The fork would be the same as the latest version without the selectors  
containting pragma preferences. Then open a new issue for 1.3 about the  
duplicates appearing in the Settings Browser.




pharo
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Issue 3620 in pharo: Settings: OCompletion settings appear twice

pharo
Updates:
        Labels: -Milestone-1.2-DevImage Milestone-1.3

Comment #15 on issue 3620 by [hidden email]: Settings: OCompletion  
settings appear twice
http://code.google.com/p/pharo/issues/detail?id=3620

(No comment was entered for this change.)


pharo
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Issue 3620 in pharo: Settings: OCompletion settings appear twice

pharo
Updates:
        Labels: -Milestone-1.3 Milestone-1.3-DevImage

Comment #16 on issue 3620 by [hidden email]: Settings: OCompletion  
settings appear twice
http://code.google.com/p/pharo/issues/detail?id=3620

(No comment was entered for this change.)


12
Free forum by Nabble Edit this page