Issue 3659 in pharo: Task bar appearance does not make sense

Status: Accepted
Owner: [hidden email]
Labels: Type-RequestForEnhancement Importance-Low

New issue 3659 by [hidden email]: Task bar appearance does not make  
sense
http://code.google.com/p/pharo/issues/detail?id=3659

Pharo 1.2rc2
Pharo core version: 12330

The buttons in the task bar are:
- frontmost window: gray background + black text
- background windows: gray background + gray text
- hidden windows: blue gradient + gray text

To me these are bad affordances, because gray text signifies "inactive or  
hidden" and color background means "active" or "current" (see the  
instance/class side buttons in the browser. So I'd change the appearances  
to reflect that:
- window visibility = text color (black = visible, gray = hidden)
- gradient color = blue for the frontmost window\

Comment #1 on issue 3659 by [hidden email]: Task bar appearance does  
not make sense
http://code.google.com/p/pharo/issues/detail?id=3659

I agree, but I could not get it to work like I wanted for the Glamorous  
Theme. It would be great if someone could take a look at this.

Comment #2 on issue 3659 by [hidden email]: Task bar appearance does  
not make sense
http://code.google.com/p/pharo/issues/detail?id=3659

In PharoInbox:  
SLICE-Issue-3659-Task-bar-appearance-does-not-make-sense-NickAlexander.2

I don't think this will be the final solution, but perhaps Tudor Girba can  
see what I've done and do it correctly.  This looks fine with the stock  
themes, but I added two new color methods to UITheme to make it work, which  
is probably not desirable.

Updates:
        Cc: tudor.girba

Comment #3 on issue 3659 by [hidden email]: Task bar appearance does  
not make sense
http://code.google.com/p/pharo/issues/detail?id=3659

Unfortunately, the slice looks empty. Could you republish?

Comment #4 on issue 3659 by [hidden email]: Task bar appearance does  
not make sense
http://code.google.com/p/pharo/issues/detail?id=3659

Hmm, it was very hard to get the slice mechanism to do anything sensible,  
so how about a change set instead?

Attachments:
        Taskbar.1.cs  2.6 KB

Comment #5 on issue 3659 by [hidden email]: Task bar appearance does  
not make sense
http://code.google.com/p/pharo/issues/detail?id=3659

Press +Slice
Fill the pop up
Select the packages you want to put in
Save slice

Comment #6 on issue 3659 by [hidden email]: Task bar appearance does  
not make sense
http://code.google.com/p/pharo/issues/detail?id=3659

This is what I did.  I then saved the slice to my local repo, and played it  
back in a fresh image; that worked fine.  I then saved that slice to the  
PharoInbox repo (after it was loaded and working into a fresh image), and  
Tudor tells me it doesn't work.

I also had tons of trouble getting the slice to not record hundreds of  
spurious changes to Polymorph-Widgets that I didn't make.

I will attempt to address another issue and try the process again, but for  
this issue, somebody else can cut the slice into PharoInbox.

Comment #7 on issue 3659 by [hidden email]: Task bar appearance does  
not make sense
http://code.google.com/p/pharo/issues/detail?id=3659

Yes dependent packages are not moved. the composite pattern is not complete.
We hijiacked dependencies to have a group of packages saved and loaded  
together.
Now there is no problem we accept cs too :)

Comment #8 on issue 3659 by [hidden email]: Task bar appearance does  
not make sense
http://code.google.com/p/pharo/issues/detail?id=3659

I have cut another slice into PharoInbox.  The slice package itself seems  
empty, but its dependent (Polymorph-Widgets) is not.

Updates:
        Labels: Milestone-1.2

Comment #9 on issue 3659 by [hidden email]: Task bar appearance does  
not make sense
http://code.google.com/p/pharo/issues/detail?id=3659

I tried it now. It looks like I would have wanted it from the beginning :)

Updates:
        Status: Fixed

Comment #10 on issue 3659 by [hidden email]: Task bar appearance  
does not make sense
http://code.google.com/p/pharo/issues/detail?id=3659

so what should I do?
Is is specific to glamour?

Comment #11 on issue 3659 by [hidden email]: Task bar appearance  
does not make sense
http://code.google.com/p/pharo/issues/detail?id=3659

No, it's not. It affects UITheme. It should be integrated in Pharo Core.

Comment #12 on issue 3659 by [hidden email]: Task bar appearance  
does not make sense
http://code.google.com/p/pharo/issues/detail?id=3659

in 1.3 then.

Updates:
        Labels: -Milestone-1.2 Milestone-1.3

Comment #13 on issue 3659 by [hidden email]: Task bar appearance  
does not make sense
http://code.google.com/p/pharo/issues/detail?id=3659

Ok, I changed the milestone.

Updates:
        Status: Closed

Comment #14 on issue 3659 by [hidden email]: Task bar appearance  
does not make sense
http://code.google.com/p/pharo/issues/detail?id=3659

In 13046