Issue 3691 in pharo: Cleaning by comparing SimpleMorphic and Morphic

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 3691 in pharo: Cleaning by comparing SimpleMorphic and Morphic

pharo
Status: Accepted
Owner: [hidden email]

New issue 3691 by [hidden email]: Cleaning by comparing  
SimpleMorphic and Morphic
http://code.google.com/p/pharo/issues/detail?id=3691

I did several cleans by comparing SimpleMorphic Canavs and FormCanvas

Attachments:
        CanvasCleaning.2.cs  36.9 KB


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3691 in pharo: Cleaning by comparing SimpleMorphic and Morphic

pharo
Updates:
        Status: Fixed
        Labels: Milestone-1.3

Comment #1 on issue 3691 by [hidden email]: Cleaning by comparing  
SimpleMorphic and Morphic
http://code.google.com/p/pharo/issues/detail?id=3691

(No comment was entered for this change.)


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3691 in pharo: Cleaning by comparing SimpleMorphic and Morphic

pharo
Updates:
        Status: FixedProposed

Comment #2 on issue 3691 by [hidden email]: Cleaning by comparing  
SimpleMorphic and Morphic
http://code.google.com/p/pharo/issues/detail?id=3691

I need some other people to look at what I did.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3691 in pharo: Cleaning by comparing SimpleMorphic and Morphic

pharo

Comment #3 on issue 3691 by [hidden email]: Cleaning by comparing  
SimpleMorphic and Morphic
http://code.google.com/p/pharo/issues/detail?id=3691

Took an initial look, fixed some comments.

Did a refactoring in FormCanvas>>setPaintColor:
(It seems i preserved the behavior, the UI was working fine after loading  
the cs)

Will continue to give it an overall look.

Attachments:
        CanvasCleaning.2.cs  25.8 KB


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3691 in pharo: Cleaning by comparing SimpleMorphic and Morphic

pharo
Updates:
        Status: Fixed

Comment #4 on issue 3691 by [hidden email]: Cleaning by comparing  
SimpleMorphic and Morphic
http://code.google.com/p/pharo/issues/detail?id=3691

Ok I will integrate that!



Reply | Threaded
Open this post in threaded view
|

Re: Issue 3691 in pharo: Cleaning by comparing SimpleMorphic and Morphic

pharo
Updates:
        Status: Closed

Comment #5 on issue 3691 by [hidden email]: Cleaning by comparing  
SimpleMorphic and Morphic
http://code.google.com/p/pharo/issues/detail?id=3691

in 13069