Issue 3707 in pharo: Syntax highlighting looks strange

Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.2-DevImage

New issue 3707 by [hidden email]: Syntax highlighting looks strange
http://code.google.com/p/pharo/issues/detail?id=3707

... especially using BOLD for variables (both global and local), but  
arguments use different color...
messages are colored (and the same as arguments).

I attach old and new png

All very strange. Especially the bold is horrible. The only bold thing in a  
method should be the method signature at the top.

Attachments:
        old.png  20.9 KB
        new.png  25.5 KB

Updates:
        Cc: Benjamin.VanRyseghem

Comment #1 on issue 3707 by [hidden email]: Syntax highlighting  
looks strange
http://code.google.com/p/pharo/issues/detail?id=3707

I will integrate first the fixes of ben for 3583

Comment #2 on issue 3707 by [hidden email]: Syntax highlighting  
looks strange
http://code.google.com/p/pharo/issues/detail?id=3707

You can change that in your settings.

I can maybe propose a fix to change default value :)

Comment #3 on issue 3707 by [hidden email]: Syntax highlighting  
looks strange
http://code.google.com/p/pharo/issues/detail?id=3707

In the latest version of GLMUITheme (from squeaksource.com/Glamour), you  
get a setPreferredShoutColors which pretty much reproduces the old  
highlighting.

Just note that this is subject to change - if I manage to find some  
references for what makes a good highlighting scheme :).

Comment #4 on issue 3707 by [hidden email]: Syntax highlighting  
looks strange
http://code.google.com/p/pharo/issues/detail?id=3707

I just committed a new version of Shout with no more bold.

But I'm not familiar with the old styling, so maybe one of you, "old"  
Smalltalker could have a look ;)

Comment #5 on issue 3707 by [hidden email]: Syntax highlighting  
looks strange
http://code.google.com/p/pharo/issues/detail?id=3707

Why don't we just change it back to how it used to be? We are *frozen* and  
want to release 1.2 ASAP (that is, 2 month ago).

Yet, someone changed compeltely everything for how syntax is colored. In a  
very ad-hoc way. it's not just the bold. The  colors are *random*.  
Selectors are colored the same as arguments, for example.

We should just revert and do experiments in 1.3.

Comment #6 on issue 3707 by [hidden email]: Syntax highlighting  
looks strange
http://code.google.com/p/pharo/issues/detail?id=3707

I agree. Do you know where these changes are?

Comment #7 on issue 3707 by [hidden email]: Syntax highlighting  
looks strange
http://code.google.com/p/pharo/issues/detail?id=3707

I do not know how this is changed but probably there is a default table  
somewhere and we can take the same as in 1.3 or 1.1

Comment #8 on issue 3707 by [hidden email]: Syntax highlighting  
looks strange
http://code.google.com/p/pharo/issues/detail?id=3707

I know where it is, I will take a look tomorrow, tonight it's party ^^

Comment #9 on issue 3707 by [hidden email]: Syntax highlighting  
looks strange
http://code.google.com/p/pharo/issues/detail?id=3707

SHTextStylerST80>>defaultStyleTable

I'm currently checking 1.0 and 1.2

Comment #10 on issue 3707 by [hidden email]: Syntax highlighting  
looks strange
http://code.google.com/p/pharo/issues/detail?id=3707

marcus from which image did you do your screen shot?
Because I tried with 1.0, 1.1 and pasted it in 1.2 but I do not get the  
same results.
and even in 1.0, 1.1 the methods do not look the same as in yours.

Comment #11 on issue 3707 by [hidden email]: Syntax highlighting  
looks strange
http://code.google.com/p/pharo/issues/detail?id=3707

BTW the bold for the instance var is nice because you can see immediately  
if the class is doing an instance variable access.
Finally I do not see why this would be a showstopper especially when there  
is a setting to change all these parameters. Looks is often quite personal.

Updates:
        Status: Fixed

Comment #12 on issue 3707 by [hidden email]: Syntax highlighting  
looks strange
http://code.google.com/p/pharo/issues/detail?id=3707

So I would close this issue.
I tried to reproduce the attached png and I cannot really see self. so cyan  
is not really adapted.

Comment #13 on issue 3707 by [hidden email]: Syntax highlighting  
looks strange
http://code.google.com/p/pharo/issues/detail?id=3707

here is the one of 1.1

defaultStyleTable
        "color can be a valid argument to Color class>>colorFrom: , or nil to
        use the editor text color.
        Multiple emphases can be specified using an array e.g. #(bold italic).
        If emphasis is not specified, #normal will be used.
        if pixel height is not specified , then the editor font size will be used.
        "
                                                               
^#(
        "(symbol color [emphasisSymbolOrArray [textStyleName [pixelHeight]]])"
                                               
        (default ( black ) )
        (invalid ( red ) )
        (excessCode ( red ) )
        (comment ( green muchDarker ) )
        (unfinishedComment ( green muchDarker ) )
        (#'$' ( magenta muchDarker) )
        (character ( magenta muchDarker) )
        (integer ( magenta muchDarker) )
        (number ( magenta muchDarker) )
        (#- ( magenta muchDarker) )
        (symbol ( magenta muchDarker) )
        (stringSymbol ( magenta muchDarker) )
        (literalArray ( magenta muchDarker) )
        (string ( magenta muchDarker) )
        (unfinishedString ( magenta muchDarker) )
        (assignment ( black ) )
        (ansiAssignment ( black ) )
        (literal ( black ) )
        (keyword ( black ) )
        (binary ( black ) )
        (unary ( black ) )
        (incompleteKeyword ( black ) )
        (incompleteBinary ( black ) )
        (incompleteUnary ( black ) )
        (undefinedKeyword ( red ) )
        (undefinedBinary ( red ) )
        (undefinedUnary ( red ) )
        (patternKeyword ( black ) bold )
        (patternBinary ( black ) bold )
        (patternUnary ( black ) bold )
        (#self ( cyan muchDarker ) )
        (#super ( cyan muchDarker ) )
        (#true ( cyan muchDarker ) )
        (#false ( cyan muchDarker ) )
        (#nil ( cyan muchDarker ) )
        (#thisContext ( cyan muchDarker ) )
        (#return ( black ) )
        (patternArg ( blue muchDarker ) )
        (methodArg ( blue muchDarker ) )
        (blockPatternArg ( blue muchDarker ) )
        (blockArg ( blue muchDarker ) )
        (argument ( blue muchDarker ) )
        (blockArgColon black )
        (leftParenthesis black )
        (rightParenthesis black )
        (leftParenthesis1 black )
        (rightParenthesis1 black )
        (leftParenthesis2 black )
        (rightParenthesis2 black )
        (leftParenthesis3 black )
        (rightParenthesis3 black )
        (leftParenthesis4 black )
        (rightParenthesis4 black )
        (leftParenthesis5 black )
        (rightParenthesis5 black )
        (leftParenthesis6 black )
        (rightParenthesis6 black )
        (leftParenthesis7 black )
        (rightParenthesis7 black )
        (blockStart black )
        (blockEnd black )
        (blockStart1 black )
        (blockEnd1 black )
        (blockStart2 black )
        (blockEnd2 black )
        (blockStart3 black )
        (blockEnd3 black )
        (blockStart4 black )
        (blockEnd4 black )
        (blockStart5 black )
        (blockEnd5 black )
        (blockStart6 black )
        (blockEnd6 black )
        (blockStart7 black )
        (blockEnd7 black )
        (arrayStart black )
        (arrayEnd black )
        (arrayStart1 black )
        (arrayEnd1 black )
        (byteArrayStart black )
        (byteArrayEnd black )
        (byteArrayStart1 black )
        (byteArrayEnd1 black )
        (leftBrace black )
        (rightBrace black )
        (cascadeSeparator black )
        (statementSeparator black )
        (externalCallType black )
        (externalCallTypePointerIndicator black )
        (primitiveOrExternalCallStart black )
        (primitiveOrExternalCallEnd black )
        (methodTempBar black )
        (blockTempBar black )
        (blockArgsBar black )
        (primitive gray )
        (externalFunctionCallingConvention gray )
        (module gray )
        (blockTempVar ( blue muchDarker ) )
        (blockPatternTempVar ( blue muchDarker ) )
        (instVar ( blue muchDarker ) )
        (workspaceVar ( blue muchDarker ) )
        (undefinedIdentifier ( red ) )
        (incompleteIdentifier ( blue muchDarker ) )
        (tempVar ( blue muchDarker ) )
        (patternTempVar ( blue muchDarker ) )
        (poolConstant ( blue muchDarker ) )
        (classVar ( blue muchDarker ) )
        (globalVar ( blue muchDarker ) ) )
                                                       

Comment #14 on issue 3707 by [hidden email]: Syntax highlighting  
looks strange
http://code.google.com/p/pharo/issues/detail?id=3707

Bold and italic do not work well with the DejaVu font. This is because in  
this font the italic / bold characters have a different width than the  
normal ones, which means that when you type your cursor will jump when  
switching between a known / unknown identifier.

Updates:
        Status: FixProposed

Comment #15 on issue 3707 by [hidden email]: Syntax highlighting  
looks strange
http://code.google.com/p/pharo/issues/detail?id=3707

(No comment was entered for this change.)

Comment #16 on issue 3707 by [hidden email]: Syntax highlighting  
looks strange
http://code.google.com/p/pharo/issues/detail?id=3707

Ok I will remove the bold and we can integrate it.

Comment #17 on issue 3707 by [hidden email]: Syntax highlighting  
looks strange
http://code.google.com/p/pharo/issues/detail?id=3707

Not only the bold. Just revert to the 1.1 style. Let's then experiment in  
1.3

Comment #18 on issue 3707 by [hidden email]: Syntax highlighting  
looks strange
http://code.google.com/p/pharo/issues/detail?id=3707

but I'm not experimenting. Reverting to the one of 1.1 does not remove the  
bold!

Comment #19 on issue 3707 by [hidden email]: Syntax highlighting  
looks strange
http://code.google.com/p/pharo/issues/detail?id=3707

so from which image do you have something ok so that I copy it?
Because else this is boring try and error.