Issue 3728 in pharo: Changed MenuMorph references to go through UIManager default menuClass

Status: New
Owner: ----

New issue 3728 by [hidden email]: Changed MenuMorph references to go  
through UIManager default menuClass
http://code.google.com/p/pharo/issues/detail?id=3728

the attached changeset replaces all the refs to the class MenuMorph by the  
usage of UIManager default menuClass.
9 uses remain, mostly due to #isKindOf: senders.

Attachments:
        menuMorphReferences.1.cs  51.7 KB

Comment #1 on issue 3728 by [hidden email]: Changed MenuMorph  
references to go through UIManager default menuClass
http://code.google.com/p/pharo/issues/detail?id=3728

Fixed

Comment #2 on issue 3728 by [hidden email]: Changed MenuMorph  
references to go through UIManager default menuClass
http://code.google.com/p/pharo/issues/detail?id=3728

Thanks indeed I was wondering what to do for the use of MenuMorph. I should  
do the same for Sound.

Updates:
        Status: Fixed

Comment #3 on issue 3728 by [hidden email]: Changed MenuMorph  
references to go through UIManager default menuClass
http://code.google.com/p/pharo/issues/detail?id=3728

(No comment was entered for this change.)

Updates:
        Labels: Milestone-1.3

Comment #4 on issue 3728 by [hidden email]: Changed MenuMorph  
references to go through UIManager default menuClass
http://code.google.com/p/pharo/issues/detail?id=3728

(No comment was entered for this change.)

Updates:
        Status: Accepted

Comment #5 on issue 3728 by [hidden email]: Changed MenuMorph  
references to go through UIManager default menuClass
http://code.google.com/p/pharo/issues/detail?id=3728

fernando I started to do something a bit better :) but we cannot attach  
anything anymore.... :(

Updates:
        Cc: fernando22480

Comment #6 on issue 3728 by [hidden email]: Changed MenuMorph  
references to go through UIManager default menuClass
http://code.google.com/p/pharo/issues/detail?id=3728

fernando can you have a look at that?

Attachments:
        MenuMorph.1.cs  9.6 KB

Updates:
        Status: FixProposed

Comment #7 on issue 3728 by [hidden email]: Changed MenuMorph  
references to go through UIManager default menuClass
http://code.google.com/p/pharo/issues/detail?id=3728

(No comment was entered for this change.)

Comment #8 on issue 3728 by [hidden email]: Changed MenuMorph  
references to go through UIManager default menuClass
http://code.google.com/p/pharo/issues/detail?id=3728

ok, will do!

Comment #9 on issue 3728 by [hidden email]: Changed MenuMorph  
references to go through UIManager default menuClass
http://code.google.com/p/pharo/issues/detail?id=3728

I 100% agree with your fix!

I also added the TEasilyThemed trait to the MorphicUIManager, it had a lot  
of duplicated methods.
Had to modify a bit the trait, with a couple of methods that were in the  
MorphicUIManager, enhacing the services methods. For example:  
chooseColor:title:.


Attachments:
        MenuMorph.2.cs  25.4 KB

Comment #10 on issue 3728 by [hidden email]: Changed MenuMorph  
references to go through UIManager default menuClass
http://code.google.com/p/pharo/issues/detail?id=3728

Apparently I cannot load your cs. Can you check if you can load it?

Comment #11 on issue 3728 by [hidden email]: Changed MenuMorph  
references to go through UIManager default menuClass
http://code.google.com/p/pharo/issues/detail?id=3728

Apparently

UIManager subclass: #MorphicUIManager
        uses: TEasilyThemed
        instanceVariableNames: 'interactiveParser '
        classVariableNames: 'Default '
        poolDictionaries: ''
        category: 'ToolBuilder-Morphic'!

is not correct since Default is already defined in superclass

UIManager subclass: #MorphicUIManager
        uses: TEasilyThemed
        instanceVariableNames: 'interactiveParser '
        classVariableNames: ''
        poolDictionaries: ''
        category: 'ToolBuilder-Morphic'!

Comment #12 on issue 3728 by [hidden email]: Changed MenuMorph  
references to go through UIManager default menuClass
http://code.google.com/p/pharo/issues/detail?id=3728

in 13073

Updates:
        Status: Closed

Comment #13 on issue 3728 by [hidden email]: Changed MenuMorph  
references to go through UIManager default menuClass
http://code.google.com/p/pharo/issues/detail?id=3728

(No comment was entered for this change.)

Comment #14 on issue 3728 by [hidden email]: Changed MenuMorph  
references to go through UIManager default menuClass
http://code.google.com/p/pharo/issues/detail?id=3728

Stef, integrate this method please. Seems that when i incorporate the trait  
TEasilyThemed to the MorphicUIManager i didn't detect that  
evaluating "UIManager default alert: 'hello'" raises an error.

Attachments:
        MorphicUIManager-openModal.st  957 bytes

Comment #15 on issue 3728 by [hidden email]: Changed MenuMorph  
references to go through UIManager default menuClass
http://code.google.com/p/pharo/issues/detail?id=3728

In 13078