Issue 3738 in pharo: Morphic Animations enhancement

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 3738 in pharo: Morphic Animations enhancement

pharo
Status: New
Owner: ----

New issue 3738 by [hidden email]: Morphic Animations enhancement
http://code.google.com/p/pharo/issues/detail?id=3738

I've implemented a Morphic-Animations runner.

The idea is to reify animations as strategy objects, that can be accessed  
and run from any Morph,  centralized in an MorphicAnimationsRunner class, (  
to avoid pupulating Morph with extra methods, similar to Seaside "brush"  
idea).

You can try it out via the examples, MorphicAnimationExamples class.

Integration with the SystemWindow is provided also, if you enable the  
animate windows setting you can give it a try.

I think this could be integated into Morphic,  as Morphic-Animations  
category.
For 1.3



Reply | Threaded
Open this post in threaded view
|

Re: Issue 3738 in pharo: Morphic Animations enhancement

pharo

Comment #1 on issue 3738 by [hidden email]: Morphic Animations  
enhancement
http://code.google.com/p/pharo/issues/detail?id=3738

In PharoInbox =>

Name: Morphic-Animations-FernandoOlivero.21
Author: FernandoOlivero
Time: 21 February 2011, 10:05:14 am
UUID: 7a6d89fa-ebb6-4288-91a2-c23f0b0d55fe
Ancestors: Morphic-Animations-FernandoOlivero.20

Animations pacakge for Morphic, please review and if fit, integrate into  
1.3 ?


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3738 in pharo: Morphic Animations enhancement

pharo

Comment #2 on issue 3738 by [hidden email]: Morphic Animations enhancement
http://code.google.com/p/pharo/issues/detail?id=3738

A few points:

Class comments? Sure, for most they're somewhat self-explanatory, but for  
say, SlideAnimation, it would be nice to know what unit the delay is in,  
and what it actually does.

There's also no common interface (that I can see) for adjusting the speed  
of the animations.

AnimationsRunner animateZoomOutOf: .... smells bad.
There's no corresponding ZoomInOf: ..., and why isn't it just zoom: aMorph  
in the first place, where new extent determines whether it is a zoom in or  
a zoom out?

AnimationsRunner class >> #uniqueInstance
Why does it use super?

Some WindowAnimation subclasses are in -Core, others in -Windows

Some animations take responsibility of all drawing up to the point where  
you copy the bits to the canvas, while others use existing methods in other  
parts of the system. Personally, I'd prefer a consistent approach in what  
is the Animations responsibility (having everything self-contained would be  
my preference)