Issue 3742 in pharo: MorphTreeMorph keyStroke: send Event object instead of Character

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 3742 in pharo: MorphTreeMorph keyStroke: send Event object instead of Character

pharo
Status: New
Owner: ----

New issue 3742 by [hidden email]: MorphTreeMorph keyStroke: send  
Event object instead of Character
http://code.google.com/p/pharo/issues/detail?id=3742

Send the full Event object instead of the Character to the model.




Attachments:
        MorphTreeMorph-keyStroke.st  1.1 KB


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3742 in pharo: MorphTreeMorph keyStroke: send Event object instead of Character

pharo
Updates:
        Cc: aplantec

Comment #1 on issue 3742 by [hidden email]: MorphTreeMorph  
keyStroke: send Event object instead of Character
http://code.google.com/p/pharo/issues/detail?id=3742

(No comment was entered for this change.)


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3742 in pharo: MorphTreeMorph keyStroke: send Event object instead of Character

pharo
Updates:
        Status: FixProposed
        Labels: Milestone-1.3

Comment #2 on issue 3742 by [hidden email]: MorphTreeMorph  
keyStroke: send Event object instead of Character
http://code.google.com/p/pharo/issues/detail?id=3742

(No comment was entered for this change.)


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3742 in pharo: MorphTreeMorph keyStroke: send Event object instead of Character

pharo

Comment #3 on issue 3742 by [hidden email]: MorphTreeMorph keyStroke:  
send Event object instead of Character
http://code.google.com/p/pharo/issues/detail?id=3742

Hi Camillo,
Why ? Normally the model only need the character not the event.
MorphTreeMorph models are considering it as a character not as an event, so  
it would break all MorphTreeMorph users.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3742 in pharo: MorphTreeMorph keyStroke: send Event object instead of Character

pharo

Comment #4 on issue 3742 by [hidden email]: MorphTreeMorph  
keyStroke: send Event object instead of Character
http://code.google.com/p/pharo/issues/detail?id=3742

I don't see a reason to only provide the character? if you work with  
anything derived from the event why not give access to the full event?

Its  not about breaking MorphTreeMorph users but about providing  
functionality. I used it to implement CMD and CTRL based actions on the  
MorphTreeMorph, Which is close to impossible if you just get the character  
in.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3742 in pharo: MorphTreeMorph keyStroke: send Event object instead of Character

pharo

Comment #5 on issue 3742 by [hidden email]: MorphTreeMorph  
keyStroke: send Event object instead of Character
http://code.google.com/p/pharo/issues/detail?id=3742

The major problem with giving only a character as parameter is that you  
can't know if the key stroke was Cmd-p or Ctrl-p (even if most of the  
Ctrl-XXX event are magically transformed on the fly by the system ...)


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3742 in pharo: MorphTreeMorph keyStroke: send Event object instead of Character

pharo

Comment #6 on issue 3742 by [hidden email]: MorphTreeMorph keyStroke:  
send Event object instead of Character
http://code.google.com/p/pharo/issues/detail?id=3742

ok, good for me, but all clients of MorphTreeMorph should be adapted.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3742 in pharo: MorphTreeMorph keyStroke: send Event object instead of Character

pharo
Updates:
        Status: closed

Comment #7 on issue 3742 by [hidden email]: MorphTreeMorph  
keyStroke: send Event object instead of Character
http://code.google.com/p/pharo/issues/detail?id=3742

already integrated