Issue 3743 in pharo: Fix Finder UI (add shortcuts and more commands)

Status: New
Owner: ----

New issue 3743 by [hidden email]: Fix Finder UI (add shortcuts and  
more commands)
http://code.google.com/p/pharo/issues/detail?id=3743

FinderUI Refactoring:
        - added decent menu items (browse, implementors...)
        - added keycommands
        - added functionality to the polymorphicly on the nodes


Take it from PharoInbox:

Name: Finder-CamilloBruni.20
Author: CamilloBruni
Time: 21 February 2011, 4:18:29 pm
UUID: 1f9006cc-7d43-40c0-bfdc-85c07f77f1ad
Ancestors: Finder-StephaneDucasse.19

Updates:
        Status: Fixed
        Cc: Benjamin.VanRyseghem.Pharo

Comment #1 on issue 3743 by [hidden email]: Fix Finder UI (add  
shortcuts and more commands)
http://code.google.com/p/pharo/issues/detail?id=3743

(No comment was entered for this change.)

Comment #2 on issue 3743 by [hidden email]: Fix Finder UI (add  
shortcuts and more commands)
http://code.google.com/p/pharo/issues/detail?id=3743

Ben can you integrate this changes? Tx

Comment #3 on issue 3743 by [hidden email]: Fix Finder UI (add  
shortcuts and more commands)
http://code.google.com/p/pharo/issues/detail?id=3743

I have posted a merged versin in PharoInbox, but since the work of Alain is  
not totally done, I haven't integrate his work.

Comment #4 on issue 3743 by [hidden email]: Fix Finder UI (add  
shortcuts and more commands)
http://code.google.com/p/pharo/issues/detail?id=3743

what is missing ?

Comment #5 on issue 3743 by [hidden email]: Fix Finder UI (add  
shortcuts and more commands)
http://code.google.com/p/pharo/issues/detail?id=3743

If I merge  Finder-BenjaminVanRyseghem.23 in the latest 1.3, I get  
conflicts.

Comment #6 on issue 3743 by [hidden email]: Fix Finder UI (add  
shortcuts and more commands)
http://code.google.com/p/pharo/issues/detail?id=3743

Issue 3724 has been merged into this issue.

Comment #7 on issue 3743 by [hidden email]: Fix Finder UI (add  
shortcuts and more commands)
http://code.google.com/p/pharo/issues/detail?id=3743

Issue 3722 has been merged into this issue.

Updates:
        Status: Accepted

Comment #8 on issue 3743 by [hidden email]: Fix Finder UI (add  
shortcuts and more commands)
http://code.google.com/p/pharo/issues/detail?id=3743

so ben the idea is that you should resolve the conflicts because we do not  
know how to resolve them but I'm sure you do.

Comment #9 on issue 3743 by [hidden email]: Fix Finder UI (add  
shortcuts and more commands)
http://code.google.com/p/pharo/issues/detail?id=3743

Merge done in  Finder-BenjaminVanRyseghem.26 in PharoInbox

Comment #10 on issue 3743 by [hidden email]: Fix Finder UI (add  
shortcuts and more commands)
http://code.google.com/p/pharo/issues/detail?id=3743

Hi Benjamin!

I've found two problems:
1) Since keyStroke: is sent with the event as argument, now you have to get  
the character from the event :)
----
keyStroke: anEvent
        anEvent  == $n ifTrue: [ ^ self browseSenders ].
----
should be
----
keyStroke: anEvent
        anEvent keyCharacter == $n ifTrue: [ ^ self browseSenders ].
----

2) the menus are not built correctly (don't know why)

Updates:
        Status: Fixed

Comment #11 on issue 3743 by [hidden email]: Fix Finder UI (add  
shortcuts and more commands)
http://code.google.com/p/pharo/issues/detail?id=3743

I just posted the version 27 on PharoInbox wich fix those two points :)

Are event send as an argument instead of a character only for Tree or have  
you fixed that for list too ?

Comment #12 on issue 3743 by [hidden email]: Fix Finder UI (add  
shortcuts and more commands)
http://code.google.com/p/pharo/issues/detail?id=3743

Two items on the wishlist:
1. Add a right-mouse popup menu so user can paste copied text into the top  
left box
    (Ctrl-v works).
2. When "Classes" is selected from the drop down box, and one of the  
Classes in
the list is highlighted:
      show either a) the filled Class template, or b) the Class comment, c)  
or both,
     in the information box at the bottom, instead of the Finder  
instructions.

Updates:
        Status: closed

Comment #13 on issue 3743 by [hidden email]: Fix Finder UI (add  
shortcuts and more commands)
http://code.google.com/p/pharo/issues/detail?id=3743

in 13067.
create a new report for following issues.