Issue 3752 in pharo: [bug+fix] Symbol>>allInstances should answer all symbols

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 3752 in pharo: [bug+fix] Symbol>>allInstances should answer all symbols

pharo
Status: New
Owner: ----

New issue 3752 by [hidden email]: [bug+fix] Symbol>>allInstances  
should answer all symbols
http://code.google.com/p/pharo/issues/detail?id=3752

Pharo image: Pharo
Pharo core version: Pharo1.2rc2 - 12330

Fixing allInstances and allInstancesDo: in Symbol.
-test provided with the new methods

Attachments:
        SymbolAllInstances.1.cs  858 bytes


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3752 in pharo: [bug+fix] Symbol>>allInstances should answer all symbols

pharo

Comment #1 on issue 3752 by [hidden email]: [bug+fix]  
Symbol>>allInstances should answer all symbols
http://code.google.com/p/pharo/issues/detail?id=3752

Why should Symbol behave differently from other classes ?
Symbol is an abstract class, just like String. It has no instances. Doing  
to Symbol what you won't do to SequenceableCollection sounds unfair.

You already have two ways to collect #allSubInstances, the slow one (4  
words before) which scans the whole object memory, and the fast one  
allSymbols which just consult the well known registry of Symbols.

Yes, for maintaining unicity of symbols, a global registry is necessary, so  
please why not use it rather than bending the meaning of a generic  
reflexion message ?

Only my 2c opinion.

See also http://bugs.squeak.org/view.php?id=6584


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3752 in pharo: [bug+fix] Symbol>>allInstances should answer all symbols

pharo

Comment #2 on issue 3752 by [hidden email]: [bug+fix]  
Symbol>>allInstances should answer all symbols
http://code.google.com/p/pharo/issues/detail?id=3752

I agree with Nicolas in that introducing exceptions like this is a bad idea


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3752 in pharo: [bug+fix] Symbol>>allInstances should answer all symbols

pharo
Updates:
        Status: WontFix

Comment #3 on issue 3752 by [hidden email]: [bug+fix]  
Symbol>>allInstances should answer all symbols
http://code.google.com/p/pharo/issues/detail?id=3752

So do we close this?


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3752 in pharo: [bug+fix] Symbol>>allInstances should answer all symbols

pharo

Comment #4 on issue 3752 by [hidden email]: [bug+fix]  
Symbol>>allInstances should answer all symbols
http://code.google.com/p/pharo/issues/detail?id=3752

Yes!