Issue 3753 in pharo: SimpleMorphic Layout Code missing

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 3753 in pharo: SimpleMorphic Layout Code missing

pharo
Status: New
Owner: ----

New issue 3753 by [hidden email]: SimpleMorphic Layout Code missing
http://code.google.com/p/pharo/issues/detail?id=3753

Cuis code for layouts is missing & I am unable to port a solitaire card  
game without them.


Pharo image: Pharo-core 2.1 rc2
Pharo core version: 12366
Virtual machine used: VM in Pharo-1.1-OneClick.app

Steps to reproduce:
1. Open a file browser and file in SimpleMorphicSolitaire.1.cs



Attachments:
        SimpleMorphSolitaire.1.cs  276 KB


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3753 in pharo: SimpleMorphic Layout Code missing

pharo

Comment #1 on issue 3753 by [hidden email]: SimpleMorphic Layout  
Code missing
http://code.google.com/p/pharo/issues/detail?id=3753

Fix submitted to Pharo inbox as SimpleMorphic-KenDickey.11.mcz

After loading the "fix" (the 2 SM layout classes) start SimpleMorphic
[Navigate to SimpleMorphic-Kernel>>SMxReadMe
  doIt on 'SimpleMorphicUIManager start'

The open a new morph from alphabetic list [Klondike or FreeCell] and play a  
game.

Note that file save/restore is broken [not yet ported/integrated.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3753 in pharo: SimpleMorphic Layout Code missing

pharo

Comment #2 on issue 3753 by [hidden email]: SimpleMorphic Layout  
Code missing
http://code.google.com/p/pharo/issues/detail?id=3753

I wrote the Solitaire code originally to understand layout in Squeak.  When  
I started looking at SimpleMorphic, but could did not find what I needed,  
so I ported the code to Cuis and then did the obvious backport.

What would be the suggested strategy to get save/restore working?  One  
natural thing would be to use Cuis' FileDialog, but this seems un-Pharo.

Suggestions?


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3753 in pharo: SimpleMorphic Layout Code missing

pharo

Comment #3 on issue 3753 by [hidden email]: SimpleMorphic Layout  
Code missing
http://code.google.com/p/pharo/issues/detail?id=3753

what do you mean by
"What would be the suggested strategy to get save/restore working?"


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3753 in pharo: SimpleMorphic Layout Code missing

pharo

Comment #4 on issue 3753 by [hidden email]: SimpleMorphic Layout  
Code missing
http://code.google.com/p/pharo/issues/detail?id=3753

I have two sets of code for save/restore of solitaire games, one which  
works in the Pharo port of the Game (ported from Squeak) and one which  
works in Cuis.

The Cuis StandardFileMenu has not been ported to Pharo SimpleMorphic.

The Pharo FileDialogWindow has not yet been integrated into Pharo  
SimpleMorphic.

So the "Save Game" and "Restore Game" buttons on the solitaire windows are  
useless.

Given my uneducated reading of the code, my belief is that Pharo's  
input/output stream implementation has diverged from that of Cuis.

It appears to me that some design decisions have to be made as to the  
style/strategy of integrating file dialogs into Pharo SimpleMorphic.

I was wondering as to suggested strategy/style, useful rubrics (rules of  
how to do things) or other hints.  Do you have any opinions on the best way  
to proceed -- or better yet can you supply me with the code?

Thanks much, -KenD
---
[PS: I note that animated card moves are quite slow in Pharo SimpleMorphic  
compared to Pharo or Cuis].


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3753 in pharo: SimpleMorphic Layout Code missing

pharo
Updates:
        Status: FixProposed

Comment #5 on issue 3753 by [hidden email]: SimpleMorphic Layout  
Code missing
http://code.google.com/p/pharo/issues/detail?id=3753

in inbox: SimpleMorphic-KenDickey.11.mcz


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3753 in pharo: SimpleMorphic Layout Code missing

pharo

Comment #6 on issue 3753 by [hidden email]: SimpleMorphic Layout  
Code missing
http://code.google.com/p/pharo/issues/detail?id=3753

Regarding the FileDialogs, the current mechanism for requesting them in  
Pharo (Morphic) is to go through the UIManager.

For instance, UIManager default confirm: 'Yes' label: 'Are you there?'.
For the specific one you mentioned, browse the remaining methods of  
UIManager in the method category 'ui-requests'

Hope it helps