Issue 3769 in pharo: Printing an object depends on #isKindOf:

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 3769 in pharo: Printing an object depends on #isKindOf:

pharo
Status: Accepted
Owner: [hidden email]

New issue 3769 by [hidden email]: Printing an object depends on  
#isKindOf:
http://code.google.com/p/pharo/issues/detail?id=3769

Due to the method:

SmalltalkEditor>>#printIt
        "Treat the current text selection as an expression; evaluate it. Insert the
        description of the result of evaluation after the selection and then make
        this description the new text selection."
        | result |
        result := self evaluateSelection.
        ((result isKindOf: FakeClassPool) or: [result == #failedDoit])
                        ifTrue: [morph flash]
                        ifFalse: [self afterSelectionInsertAndSelect: result printString]


So when trying to print an object which is an instance of a class which  
directly inherits from ProtoObject, it raises an error


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3769 in pharo: Printing an object depends on #isKindOf:

pharo

Comment #1 on issue 3769 by [hidden email]: Printing an object  
depends on #isKindOf:
http://code.google.com/p/pharo/issues/detail?id=3769

Anyway, you'll have to remove references to FakeClassPool. See #3704


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3769 in pharo: Printing an object depends on #isKindOf:

pharo

Comment #2 on issue 3769 by [hidden email]: Printing an object  
depends on #isKindOf:
http://code.google.com/p/pharo/issues/detail?id=3769

Yes we will remove them this is on my radar.



Reply | Threaded
Open this post in threaded view
|

Re: Issue 3769 in pharo: Printing an object depends on #isKindOf:

pharo
Updates:
        Status: FixProposed
        Labels: Milestone-1.3

Comment #3 on issue 3769 by [hidden email]: Printing an object  
depends on #isKindOf:
http://code.google.com/p/pharo/issues/detail?id=3769

Name: SLICE-Issue-3769-remove-FakeClassPool-nice.1
Dependencies: Morphic-nice.875, SimpleMorphic-nice.22,  
Deprecated13-nice.10, Tools-nice.574, System-Text-nice.154,  
System-Tools-nice.44

remove FakeClassPool because it does not serve any useful feature.

Rather than testing an evaluation result for (FakeClassPool) kind or  
#failedDoit, it is better and simpler to use the ifFail block provided in  
Compiler evaluate message.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3769 in pharo: Printing an object depends on #isKindOf:

pharo
Updates:
        Status: Closed

Comment #4 on issue 3769 by [hidden email]: Printing an object  
depends on #isKindOf:
http://code.google.com/p/pharo/issues/detail?id=3769

in 13125