Issue 3789 in pharo: convert MenuMorph reference to invoke UIManager

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 3789 in pharo: convert MenuMorph reference to invoke UIManager

pharo
Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.3

New issue 3789 by [hidden email]: convert MenuMorph reference to  
invoke UIManager
http://code.google.com/p/pharo/issues/detail?id=3789

subMenu := MenuMorph new defaultTarget: self.

should be turned into

subMenu := UIManager default
                        newMenuIn: self for: self.


newMenuIn: <owner> like a pane for example for: receiver of the menu  
actions.

This is related to issue: 3728


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3789 in pharo: convert MenuMorph reference to invoke UIManager

pharo

Comment #1 on issue 3789 by [hidden email]: convert MenuMorph  
reference to invoke UIManager
http://code.google.com/p/pharo/issues/detail?id=3789

SLICE committed


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3789 in pharo: convert MenuMorph reference to invoke UIManager

pharo

Comment #2 on issue 3789 by [hidden email]: convert MenuMorph  
reference to invoke UIManager
http://code.google.com/p/pharo/issues/detail?id=3789

And of course, it's broken :)

First I made the slice from a dev imageā€¦
Then, UIManager default does not understand newMenuIn:for:. Only  
implementor is UITheme??

Reply | Threaded
Open this post in threaded view
|

Re: Issue 3789 in pharo: convert MenuMorph reference to invoke UIManager

pharo

Comment #3 on issue 3789 by [hidden email]: convert MenuMorph  
reference to invoke UIManager
http://code.google.com/p/pharo/issues/detail?id=3789

?

UIManager>>newMenuIn: aThemedMorph for: aModel
        "Answer a new menu."
       
        ^ self subclassResponsibility


MorphicUIManager>>newMenuIn: aThemedMorph for: aModel
        "Answer a new menu."
        "UIManager default"
        ^self theme
                newMenuIn: aThemedMorph for: aModel

so what is the problem?


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3789 in pharo: convert MenuMorph reference to invoke UIManager

pharo
Updates:
        Labels: -Milestone-1.3

Comment #4 on issue 3789 by [hidden email]: convert MenuMorph  
reference to invoke UIManager
http://code.google.com/p/pharo/issues/detail?id=3789

(No comment was entered for this change.)


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3789 in pharo: convert MenuMorph reference to invoke UIManager

pharo

Comment #5 on issue 3789 by [hidden email]: convert MenuMorph  
reference to invoke UIManager
http://code.google.com/p/pharo/issues/detail?id=3789

Issue 3972 has been merged into this issue.