Issue 3808 in pharo: Process should not depend on the debugger

Status: Accepted
Owner: [hidden email]

New issue 3808 by [hidden email]: Process should not depend on the  
debugger
http://code.google.com/p/pharo/issues/detail?id=3808

Process>>debugWithTitle: title
        "Open debugger on self"

        | context |
        context := self isActiveProcess ifTrue: [thisContext] ifFalse: [self  
suspendedContext].
        self debug: context title: title full: true.


Process>>terminate
        "Stop the process that the receiver represents forever.  Unwind to execute  
pending ensure:/ifCurtailed: blocks before terminating."

        | ctxt unwindBlock oldList |
        self isActiveProcess
                ifTrue: [
                        ctxt := thisContext.
                        [ ctxt := ctxt findNextUnwindContextUpTo: nil.
                        ctxt isNil ] whileFalse:
                                [ (ctxt tempAt: 2) ifNil:
                                        [ ctxt tempAt: 2 put: nil.
                                        unwindBlock := ctxt tempAt: 1.
                                        thisContext terminateTo: ctxt.
                                        unwindBlock value ]].
                        thisContext terminateTo: nil.
                        self suspend ]
                 ifFalse: [
                        "Always suspend the process first so it doesn't accidentally get woken  
up"
                         oldList := self suspend.
                        suspendedContext ifNotNil:[
                                "Figure out if we are terminating the process while waiting in  
Semaphore>>critical:
                                In this case, pop the suspendedContext so that we leave the ensure:  
block inside
                                Semaphore>>critical: without signaling the semaphore."
                                (oldList class == Semaphore and:[
                                        suspendedContext method == (Semaphore compiledMethodAt: #critical:)])  
ifTrue:[
                                                suspendedContext := suspendedContext home.].
                                       
                          "If we are terminating a process halfways through an unwind, try to  
complete that unwind block first."
                                (suspendedContext findNextUnwindContextUpTo: nil) ifNotNil: [ :outer |
                                (suspendedContext findContextSuchThat: [ :c | c closure == (outer  
tempAt: 1)])
                                        ifNotNil: [ :inner |
                                                 "This is an unwind block currently under evaluation"
                                                suspendedContext runUntilErrorOrReturnFrom: inner ]].
                        ctxt := self popTo: suspendedContext bottomContext.
                        ctxt == suspendedContext bottomContext ifFalse: [
                                self debug: ctxt title: 'Unwind error during termination']] ].


We should probably raise an exception and catch it somewhere.