Issue 3845 in pharo: Polymorph extension shortSummary is not programmed the object way

Status: Accepted
Owner: [hidden email]

New issue 3845 by [hidden email]: Polymorph extension shortSummary  
is not programmed the object way
http://code.google.com/p/pharo/issues/detail?id=3845

It is programmed with a sequence of

self isThisOrThat ifTrue: [] ifFalse: []

Please don't do that.
Just implement a shortSummary where due (with default behaviour ^summary)  
and use it !

With current shortSummary implementation, a MC with a postscript cannot be  
diffed.

Updates:
        Status: FixProposed

Comment #1 on issue 3845 by [hidden email]: Polymorph extension  
shortSummary is not programmed the object way
http://code.google.com/p/pharo/issues/detail?id=3845

Name:  
SLICE-Issue-3845-Polymorph-Diff-Tool-shortSummary-fails-for-postscript-nice.1
Dependencies: Polymorph-Tools-Diff-nice.49

Implement #shortSummary in subclasses rather than using ifTrue:ifFalse:  
chains
Reminder: these chains fail in case mcz includes a Postscript...

While at it, also sort the changes in a patch morph class-name-wise
(though this should be a different Issue, but everyone shall know how lazy  
I can be at this time of the night)
Note that the implementation is different from PSMCMergeMorph>>#model:
But MC+Polymorph together makes such a big number of classes that I won't  
try to be any clever and won't spend any time guessing a way to factor this  
code out.

Updates:
        Status: Closed
        Labels: Milestone-1.3

Comment #2 on issue 3845 by [hidden email]: Polymorph extension  
shortSummary is not programmed the object way
http://code.google.com/p/pharo/issues/detail?id=3845

I'm currently going slowly in MC to understand how to integrate RPackage  
and I would have loved to get more comments (right now this is nearly  
zero)... so there is no problem with not factoring out such logic since it  
is simple

Integrated in 1318