Issue 3872 in pharo: [Failing Test] 1.3 HttpUrlTest.testHttps

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 3872 in pharo: [Failing Test] 1.3 HttpUrlTest.testHttps

pharo
Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.3

New issue 3872 by [hidden email]: [Failing Test] 1.3  
HttpUrlTest.testHttps
http://code.google.com/p/pharo/issues/detail?id=3872

>>> NetworkTests.Url.HttpUrlTest.testHttps 0.0010 99



Reply | Threaded
Open this post in threaded view
|

Re: Issue 3872 in pharo: [Failing Test] 1.3 HttpUrlTest.testHttps

pharo

Comment #1 on issue 3872 by [hidden email]: [Failing Test] 1.3  
HttpUrlTest.testHttps
http://code.google.com/p/pharo/issues/detail?id=3872

Name: SLICE-Issue-3872-TestHttpsParseScheme-SvenVanCaekenberghe.1
Author: SvenVanCaekenberghe
Time: 15 April 2011, 11:53:35 am
UUID: 84cdb3e8-7ecb-4383-8f33-a0d90df3020c
Ancestors:
Dependencies: NetworkTests-SvenVanCaekenberghe.46

test https url parsing for scheme only, not class


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3872 in pharo: [Failing Test] 1.3 HttpUrlTest.testHttps

pharo
Updates:
        Status: FixProposed

Comment #2 on issue 3872 by [hidden email]: [Failing Test] 1.3  
HttpUrlTest.testHttps
http://code.google.com/p/pharo/issues/detail?id=3872

(No comment was entered for this change.)


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3872 in pharo: [Failing Test] 1.3 HttpUrlTest.testHttps

pharo

Comment #3 on issue 3872 by [hidden email]: [Failing Test] 1.3  
HttpUrlTest.testHttps
http://code.google.com/p/pharo/issues/detail?id=3872

The current implementation allows only one schemeName/urlClass.

Simple solution: Introduce a subclass of HttpUrl HttpsUrl returning 'https'  
as schemeName, and change the test to

testHttps
        self assert: 'https://encrypted.google.com' asUrl class == HttpsUrl


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3872 in pharo: [Failing Test] 1.3 HttpUrlTest.testHttps

pharo
Updates:
        Status: Closed

Comment #4 on issue 3872 by [hidden email]: [Failing Test] 1.3  
HttpUrlTest.testHttps
http://code.google.com/p/pharo/issues/detail?id=3872

(No comment was entered for this change.)


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3872 in pharo: [Failing Test] 1.3 HttpUrlTest.testHttps

pharo
Updates:
        Status: FixToInclude

Comment #5 on issue 3872 by [hidden email]: [Failing Test] 1.3  
HttpUrlTest.testHttps
http://code.google.com/p/pharo/issues/detail?id=3872

hhmm... seems to have been omited on the actual updated


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3872 in pharo: [Failing Test] 1.3 HttpUrlTest.testHttps

pharo
Updates:
        Status: Closed

Comment #6 on issue 3872 by [hidden email]: [Failing Test] 1.3  
HttpUrlTest.testHttps
http://code.google.com/p/pharo/issues/detail?id=3872

(No comment was entered for this change.)