Issue 3921 in pharo: due to *graphics package, we lost some string changes

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 3921 in pharo: due to *graphics package, we lost some string changes

pharo
Status: Accepted
Owner: [hidden email]

New issue 3921 by [hidden email]: due to *graphics package, we lost  
some string changes
http://code.google.com/p/pharo/issues/detail?id=3921

displayOn: aDisplayMedium at: aPoint textColor: aColor

send asDisplayText which is not there.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3921 in pharo: due to *graphics package, we lost some string changes

pharo

Comment #1 on issue 3921 by [hidden email]: due to *graphics  
package, we lost some string changes
http://code.google.com/p/pharo/issues/detail?id=3921

In Issue 3584, i deprecated DisplayText and the use in string.

I changed the implementation of displayOn:at:textColor: to not use  
asDisplayText, and call the Canvas drawString: method instead.  (Based on  
CUIS implementation, that also removed the class DisplayText)

I dont fully understand this issue, could you please clarify a bit?, i dont  
understand why it relates to *graphics package


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3921 in pharo: due to *graphics package, we lost some string changes

pharo

Comment #2 on issue 3921 by [hidden email]: due to *graphics  
package, we lost some string changes
http://code.google.com/p/pharo/issues/detail?id=3921

So by having the method in *graphics, they are part of the Graphics  
package. But this package has no MC repository, so when saving the code, it  
was skipped.

(there should be no *graphics package, there are muttiple graphics-  
packages, having an *graphics package in addition confuses Monticello  
completely...)


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3921 in pharo: due to *graphics package, we lost some string changes

pharo
Updates:
        Status: FixToInclude
        Labels: Milestone-1.3

Comment #3 on issue 3921 by [hidden email]: due to *graphics  
package, we lost some string changes
http://code.google.com/p/pharo/issues/detail?id=3921

lost method attached

Attachments:
        String-displayOnattextColor.st  389 bytes


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3921 in pharo: due to *graphics package, we lost some string changes

pharo
Updates:
        Status: Closed

Comment #4 on issue 3921 by [hidden email]: due to *graphics  
package, we lost some string changes
http://code.google.com/p/pharo/issues/detail?id=3921

in 13130