Issue 3948 in pharo: Transcript and ThreadedTranscript needs to be merged

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 3948 in pharo: Transcript and ThreadedTranscript needs to be merged

pharo
Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.3

New issue 3948 by [hidden email]: Transcript and ThreadedTranscript  
needs to be merged
http://code.google.com/p/pharo/issues/detail?id=3948

Transcript is now not a Stream subclass anymore.

ThreadedTranscript's install method now destroys the Transcript class.

Transcript now has a semaphore, so maybe it is thread safe?

merge needed.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3948 in pharo: Transcript and ThreadedTranscript needs to be merged

pharo

Comment #1 on issue 3948 by [hidden email]: Transcript and  
ThreadedTranscript needs to be merged
http://code.google.com/p/pharo/issues/detail?id=3948

Transcript is designed to be thread safe.
Regarding the merge, i've replaced every use of ThreadedTranscript with  
(new) Transcript. Maybe i've omitted something?


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3948 in pharo: Transcript and ThreadedTranscript needs to be merged

pharo

Comment #2 on issue 3948 by [hidden email]: Transcript and  
ThreadedTranscript needs to be merged
http://code.google.com/p/pharo/issues/detail?id=3948

I've replaced the Transcript class with an equal TranscriptModel instance,  
reverting to the use of a global Transcript, according to Igors suggestion.
I also modified a bit the TranscriptMorph, to denote the read-only nature  
of the text. (Igor suggested to be able to select the text as well, not yet  
there); and changed all the uses ( in Core) to go through StandardToolSet  
openTranscript.



First load the changeset, then evaluate the contents of the saved workspace.

Attachments:
        TranscriptModelLoad.1.cs  14.0 KB
        TranscriptPostLoad.ws  404 bytes


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3948 in pharo: Transcript and ThreadedTranscript needs to be merged

pharo
Updates:
        Status: FixProposed

Comment #3 on issue 3948 by [hidden email]: Transcript and  
ThreadedTranscript needs to be merged
http://code.google.com/p/pharo/issues/detail?id=3948

(No comment was entered for this change.)