Issue 3966 in pharo: String>>lines misses tests

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 3966 in pharo: String>>lines misses tests

pharo
Status: FixToInclude
Owner: [hidden email]
Labels: Type-Patch Difficulty-Easy Importance-Low Milestone-1.2.2

New issue 3966 by [hidden email]: String>>lines misses tests
http://code.google.com/p/pharo/issues/detail?id=3966

I've written a simple test for String>>lines:

testLines
        | sampleCRString sampleLFString sampleCRLFString |
        sampleCRString := 'Fred', String cr , 'the' , String cr , 'Bear'.
        sampleLFString := 'Fred', String lf , 'the' , String lf , 'Bear'.
        sampleCRLFString := 'Fred', String crlf , 'the' , String crlf , 'Bear'.
       
        self assert: sampleCRString lines = #('Fred' 'the'  'Bear').
        self assert: sampleLFString lines = #('Fred' 'the'  'Bear').
        self assert: sampleCRLFString lines = #('Fred' 'the'  'Bear').


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3966 in pharo: String>>lines misses tests

pharo

Comment #1 on issue 3966 by [hidden email]: String>>lines misses  
tests
http://code.google.com/p/pharo/issues/detail?id=3966

Name: CollectionsTests-DamienCassou.496
Author: DamienCassou
Time: 6 April 2011, 8:28:06 am
UUID: 9e1c8adf-05ab-4ab7-9d36-382ad618ddaa
Ancestors: CollectionsTests-MarcusDenker.495

- Issue 3966: String>>lines misses tests. This commit adds a test for  
String>>lines


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3966 in pharo: String>>lines misses tests

pharo

Comment #2 on issue 3966 by [hidden email]: String>>lines misses  
tests
http://code.google.com/p/pharo/issues/detail?id=3966

tx!



Reply | Threaded
Open this post in threaded view
|

Re: Issue 3966 in pharo: String>>lines misses tests

pharo

Comment #3 on issue 3966 by [hidden email]: String>>lines misses  
tests
http://code.google.com/p/pharo/issues/detail?id=3966

There could also be a test with mixed conventions because it is a feature  
of #lines


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3966 in pharo: String>>lines misses tests

pharo
Updates:
        Status: Closed
        Labels: -Milestone-1.2.2 Milestone-1.3

Comment #4 on issue 3966 by [hidden email]: String>>lines misses  
tests
http://code.google.com/p/pharo/issues/detail?id=3966

in 13134 (test extended to cover mixed case)