Issue 3991 in pharo: use them instead of UITheme current

Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.3

New issue 3991 by [hidden email]: use them instead of UITheme current
http://code.google.com/p/pharo/issues/detail?id=3991

I found

theme
        "Answer the current theme for the receiver."

        (self valueOfProperty: #theme) ifNotNil: [:t | ^ t].
        ^(self window ifNil: [self class]) theme

in Morph

theme: aUITheme
        "Set the current theme for the receiver."

        self theme = aUITheme ifFalse: [
                self setProperty: #theme toValue: aUITheme.
                self themeChanged]

and theme is defined on the Morph class so this means that we can change  
the UITheme current by self theme :)


Stef

Comment #1 on issue 3991 by [hidden email]: use them instead of  
UITheme current
http://code.google.com/p/pharo/issues/detail?id=3991

I modified the refs, stil some remain, in some deprecated classes such as  
MenuIcons and some PolymorphSettings.
I decided to add the method theme ^ UITheme current, whenver the object did  
not understand theme ( a non morph object), so we easily trace those by  
browsing implementors of #theme.


Attachments:
        UIThemeRefsFix.2.cs  76.1 KB

Updates:
        Status: FixProposed

Comment #2 on issue 3991 by [hidden email]: use them instead of  
UITheme current
http://code.google.com/p/pharo/issues/detail?id=3991

Yes I started to do that too. So cool I will have a look.

Comment #3 on issue 3991 by [hidden email]: use them instead of  
UITheme current
http://code.google.com/p/pharo/issues/detail?id=3991

in 13146

Updates:
        Status: Closed

Comment #4 on issue 3991 by [hidden email]: use them instead of  
UITheme current
http://code.google.com/p/pharo/issues/detail?id=3991

(No comment was entered for this change.)