Issue 4015 in pharo: Fix in SmalltalkEditor

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 4015 in pharo: Fix in SmalltalkEditor

pharo
Status: FixProposed
Owner: [hidden email]
Labels: Nautilus

New issue 4015 by [hidden email]: Fix in SmalltalkEditor
http://code.google.com/p/pharo/issues/detail?id=4015

Related to: Issue 3908: Fix for pool variables references

I have introduced a new method to retrieve the model selectedClass.

Because the method name is different in Browser and in  
Nautilus/Finder/RML... I've also introduced a ugly dispatch ...

I think this method name shouldn't be hardcoded, but I haven't any clue how  
to do it other than provided it to the SmalltalkEditor which sucks ...

Attachments:
        SmalltalkEditor.BenjaminVanRyseghem.2.cs  3.0 KB


Reply | Threaded
Open this post in threaded view
|

Re: Issue 4015 in pharo: Fix in SmalltalkEditor

pharo

Comment #1 on issue 4015 by [hidden email]: Fix in SmalltalkEditor
http://code.google.com/p/pharo/issues/detail?id=4015

I would ban or refactor selectedClassOrMetaClass.
First, it should be Metaclass rather than MetaClass.
Then, it should be selectedClassOrMetaclassOrTraitOrClassTrait given  
current implementation.
And finally, why not just selectedBehavior ?

Maybe both should be selectedBehavior.
Just add it to your dispatch method for a transient time (to avoid  
complaints coming from various OB, O2 & co), then zap the entire workaround.



Reply | Threaded
Open this post in threaded view
|

Re: Issue 4015 in pharo: Fix in SmalltalkEditor

pharo

Comment #2 on issue 4015 by [hidden email]: Fix in SmalltalkEditor
http://code.google.com/p/pharo/issues/detail?id=4015

A new change set, in addition of the previous one

Attachments:
        SmalltalkEditor-modelCurrentSelectedClass.st  839 bytes


Reply | Threaded
Open this post in threaded view
|

Re: Issue 4015 in pharo: Fix in SmalltalkEditor

pharo
Updates:
        Status: Closed

Comment #3 on issue 4015 by [hidden email]: Fix in SmalltalkEditor
http://code.google.com/p/pharo/issues/detail?id=4015

in 13151


Reply | Threaded
Open this post in threaded view
|

Re: Issue 4015 in pharo: Fix in SmalltalkEditor

pharo
Updates:
        Status: FixProposed

Comment #4 on issue 4015 by [hidden email]: Fix in SmalltalkEditor
http://code.google.com/p/pharo/issues/detail?id=4015

ups, not yes


Reply | Threaded
Open this post in threaded view
|

Re: Issue 4015 in pharo: Fix in SmalltalkEditor

pharo
Updates:
        Status: Closed

Comment #5 on issue 4015 by [hidden email]: Fix in SmalltalkEditor
http://code.google.com/p/pharo/issues/detail?id=4015

in 13153