Issue 4069 in pharo: Object>>withArgs:executeMethod: should be removed

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 4069 in pharo: Object>>withArgs:executeMethod: should be removed

pharo
Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.3

New issue 4069 by [hidden email]: Object>>withArgs:executeMethod:  
should be removed
http://code.google.com/p/pharo/issues/detail?id=4069

We should use instead

CompiledMethod >> valueWithReceiver: aReceiver arguments: anArray
    "Execute compiledMethod against the receiver and args in argArray. The  
receiver is the CompiledMethod"
<primitive: 666>
    self primitiveFailed

discussion on vmdev


On Wed, 20 Apr 2011, Andreas Raab wrote:


Which by the way, is the primitive that should exist, and  
Object>>withArgs:executeMethod: should be nuked ASAP. There is no reason to  
pollute the Object namespace any more than absolutely necessary.

Right. AFAIK #withArgs:executeMethod: and friends were part of Marcus'  
closure implementation, so there's also no need for them anymore.


Levente


Cheers,
- Andreas



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4069 in pharo: Object>>withArgs:executeMethod: should be removed

pharo

Comment #1 on issue 4069 by [hidden email]:  
Object>>withArgs:executeMethod: should be removed
http://code.google.com/p/pharo/issues/detail?id=4069

#withArgs:executeMethod: (Primitives 188)

Does not come from the old closures. What was added back then were "go  
faster" specializations
that do not need an Array to be passed (Primitive 189).

Yes, a primitive on CompiledMethod is far better. But

#withArgs:executeMethod:

is used to execute #doits, at least in Pharo. So we can not yet remove it  
if there is no alternative.

the special ones calling calling Primitive 189 can be removed / deprecated  
with no problem.
(no senders).




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4069 in pharo: Object>>withArgs:executeMethod: should be removed

pharo

Comment #2 on issue 4069 by [hidden email]:  
Object>>withArgs:executeMethod: should be removed
http://code.google.com/p/pharo/issues/detail?id=4069

Fix attached to deprecated Primitive 189 methods

Attachments:
        DeprecatedPrimitive189.1.cs  2.7 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4069 in pharo: Object>>withArgs:executeMethod: should be removed

pharo
Updates:
        Status: FixProposed

Comment #3 on issue 4069 by [hidden email]:  
Object>>withArgs:executeMethod: should be removed
http://code.google.com/p/pharo/issues/detail?id=4069

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4069 in pharo: Object>>withArgs:executeMethod: should be removed

pharo
Updates:
        Status: Closed

Comment #4 on issue 4069 by [hidden email]:  
Object>>withArgs:executeMethod: should be removed
http://code.google.com/p/pharo/issues/detail?id=4069

in 13174


        we deprecate the specialized version (Prim 189), but keep  
#withArgs:executeMethod: for now until
        there is a primitive for CompiledMethod... (this is used for executing  
DoIts).
        For the next step, we will add another Issue later.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4069 in pharo: Object>>withArgs:executeMethod: should be removed

pharo
Updates:
        Labels: MigratedToFogBugz

Comment #5 on issue 4069 by [hidden email]:  
Object>>withArgs:executeMethod: should be removed
http://code.google.com/p/pharo/issues/detail?id=4069#c5

Issue migrated to https://pharo.fogbugz.com/f/cases/4115

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker