Issue 4073 in pharo: Prettyprint hides ending comments if last line of code ends in period

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 4073 in pharo: Prettyprint hides ending comments if last line of code ends in period

pharo
Status: New
Owner: ----

New issue 4073 by [hidden email]: Prettyprint hides ending comments  
if last line of code ends in period
http://code.google.com/p/pharo/issues/detail?id=4073

Pharo image: Pharo-core
Pharo core version: Pharo1.3a
Latest update: #13144
Virtual machine used: <Pharo4.1.1 on Win32>
Class browser used (if applicable): "SystemBrowser default"

Prettyprint removes the final period to code. But it also removes any  
comments after the period too.  If there is no period at the end of the  
last line of code, then the comment will appear when in prettyprint viewing  
mode.

Steps to reproduce:
1. Select any method in a Browser (the one that's with Core)
2. add a comment after last line of code, use ending period (y :=4.):
i.e.
test1
| x y |
x := 0.
y := 4.
"comment"

3. save.

4. switch viewing mode to PrettyPrint.
The ending period and the comment following the period all disappear.

5.  switch back to Source viewing mode.
The ending period and the comment reappear.

6. Note: if the code has no a period (y := 4), the comment is not hidden:

test2
| x y |
x := 0.
y := 4
"comment"




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4073 in pharo: Prettyprint hides ending comments if last line of code ends in period

pharo

Comment #1 on issue 4073 by [hidden email]: Prettyprint hides ending  
comments if last line of code ends in period
http://code.google.com/p/pharo/issues/detail?id=4073

Yes this is a known limit of the pretty print


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4073 in pharo: Prettyprint hides ending comments if last line of code ends in period

pharo
Updates:
        Cc: renggli

Comment #2 on issue 4073 by marianopeck: Prettyprint hides ending comments  
if last line of code ends in period
http://code.google.com/p/pharo/issues/detail?id=4073

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4073 in pharo: Prettyprint hides ending comments if last line of code ends in period

pharo
Updates:
        Cc: -renggli

Comment #3 on issue 4073 by renggli: Prettyprint hides ending comments if  
last line of code ends in period
http://code.google.com/p/pharo/issues/detail?id=4073

This is a problem of the Pharo compiler, not the Pretty Printer in the  
refactoring engine (this one works fine).


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4073 in pharo: Prettyprint hides ending comments if last line of code ends in period

pharo
Updates:
        Status: Duplicate
        Mergedinto: 1244

Comment #4 on issue 4073 by renggli: Prettyprint hides ending comments if  
last line of code ends in period
http://code.google.com/p/pharo/issues/detail?id=4073

In fact this is a duplicate of Issue 1244.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4073 in pharo: Prettyprint hides ending comments if last line of code ends in period

pharo
Updates:
        Labels: MigratedToFogBugz

Comment #5 on issue 4073 by [hidden email]: Prettyprint hides ending  
comments if last line of code ends in period
http://code.google.com/p/pharo/issues/detail?id=4073#c5

Issue migrated to https://pharo.fogbugz.com/f/cases/4119

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker