Issue 4095 in pharo: Suggestion: rename some methods for consistency

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 4095 in pharo: Suggestion: rename some methods for consistency

pharo
Status: New
Owner: ----

New issue 4095 by [hidden email]: Suggestion: rename some methods  
for consistency
http://code.google.com/p/pharo/issues/detail?id=4095

Pharo image: Pharo-core
Pharo core version: Pharo1.3a
Latest update: #13172
Virtual machine used: <Pharo4.1.1 on Win32>
Class browser used (if applicable): "SystemBrowser default"

The vast majority of example methods follow a consistent naming pattern  
where
the word 'example' starts the method name. There's a handful that don't.

The advantage of this approach is that all the examples appear together in
the browser list of methods.

I suggest that these methods be renamed:

   BorderedMorph class >> gradientExample
     --> exampleGradient
   SimpleHierarchicalListMorph class >> submorphsExample
     --> exampleSubmorphs
   PluggableMenuSpec class >> withOneSingleItemExample
     --> exampleWithOneSingleItem
   PluggableMenuSpec class >> withSubMenuExample
     --> exampleWithSubMenu
   PluggableMenuSpec class >> withTwoSimpleItemsExample
     --> exampleWithTwoSimpleItems
   DigitalSignatureAlgorith >> writeExamplesToDisk
     --> exampleWriteToDisk
   UITheme class >> textEntryWithCompletionDialog
     --> exampletextEntryWithCompletionDialog
   UITheme class >> closeExampleDialogs
     --> exampleCloseDialogs

  (I've excluded test and testcase examples from this list).



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4095 in pharo: Suggestion: rename some methods for consistency

pharo

Comment #1 on issue 4095 by [hidden email]: Suggestion: rename some  
methods for consistency
http://code.google.com/p/pharo/issues/detail?id=4095

Should be easy to do, however it may be possible that some of them
are mentioned in one of the Pharo books. Do we care?

exampletextEntryWithCompletionDialog => exampleTextEntryWithCompletionDialog


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4095 in pharo: Suggestion: rename some methods for consistency

pharo

Comment #2 on issue 4095 by marianopeck: Suggestion: rename some methods  
for consistency
http://code.google.com/p/pharo/issues/detail?id=4095

No. I wouldn't care about the book. We need to make progress. If these  
renames make sense, just go ahead :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4095 in pharo: Suggestion: rename some methods for consistency

pharo
Updates:
        Status: Accepted
        Labels: Type-Cleanup

Comment #3 on issue 4095 by [hidden email]: Suggestion: rename some  
methods for consistency
http://code.google.com/p/pharo/issues/detail?id=4095

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4095 in pharo: Suggestion: rename some methods for consistency

pharo
Updates:
        Status: FixToInclude
        Labels: Milestone-2.0

Comment #4 on issue 4095 by [hidden email]: Suggestion: rename some  
methods for consistency
http://code.google.com/p/pharo/issues/detail?id=4095

Name:  
SLICE-Issue-4095-Suggestion-rename-some-methods-for-consistency-MarcusDenker.1
Author: MarcusDenker
Time: 8 July 2012, 12:16:19.844 pm
UUID: 0066e735-925b-470b-a109-b4a6c284a60a
Ancestors:
Dependencies: Polymorph-Widgets-MarcusDenker.662, Morphic-MarcusDenker.1188

Issue 4095: Suggestion: rename some methods for consistency


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4095 in pharo: Suggestion: rename some methods for consistency

pharo
Updates:
        Status: Integrated

Comment #5 on issue 4095 by [hidden email]: Suggestion: rename some  
methods for consistency
http://code.google.com/p/pharo/issues/detail?id=4095

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4095 in pharo: Suggestion: rename some methods for consistency

pharo
Updates:
        Labels: MigratedToFogBugz

Comment #6 on issue 4095 by [hidden email]: Suggestion: rename some  
methods for consistency
http://code.google.com/p/pharo/issues/detail?id=4095#c6

Issue migrated to https://pharo.fogbugz.com/f/cases/4141

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker