Issue 4107 in pharo: Pretty print settings does not work for OBSystemBrowserAdaptor

Status: New
Owner: [hidden email]

New issue 4107 by [hidden email]: Pretty print settings does not  
work for OBSystemBrowserAdaptor
http://code.google.com/p/pharo/issues/detail?id=4107

Pharo core image:  
https://pharo-ic.lille.inria.fr/hudson/view/Pharo/job/Pharo%201.3/111/

When selecting in settings browser "Pretty Print", the code is not pretty  
print with OBSystemBrowserAdaptor,
but is prettyprint with "Browser"


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Type-ReportDefect

Comment #1 on issue 4107 by [hidden email]: Pretty print settings  
does not work for OBSystemBrowserAdaptor
http://code.google.com/p/pharo/issues/detail?id=4107

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: renggli

Comment #2 on issue 4107 by marianopeck: Pretty print settings does not  
work for OBSystemBrowserAdaptor
http://code.google.com/p/pharo/issues/detail?id=4107

Aha. Good catch.
I am not sure if OB supports that, but it case it does, we should be able  
to just set that setting.

Lukas do you know?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4107 by renggli: Pretty print settings does not work  
for OBSystemBrowserAdaptor
http://code.google.com/p/pharo/issues/detail?id=4107

I don't understand the issue: What does

     the code is not pretty print with OBSystemBrowserAdaptor,
     but is prettyprint with "Browser"

mean?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4107 by [hidden email]: Pretty print settings  
does not work for OBSystemBrowserAdaptor
http://code.google.com/p/pharo/issues/detail?id=4107

There is a setting in the Settings Brower called : "pretty print" (under  
Code browing item). When this setting is selected and you use the default  
browser (OBSystemBrowserAdaptor) there is no pretty print of code when you  
accept a method. But when you use a simple "Browser", the prettyprint is  
done automatically.
Still unclear ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WontFix

Comment #5 on issue 4107 by renggli: Pretty print settings does not work  
for OBSystemBrowserAdaptor
http://code.google.com/p/pharo/issues/detail?id=4107

This setting is specific for the old browser. OB and RB has its own  
settings to pretty print on-show and/or on-accept (see in the refactoring  
category).


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #6 on issue 4107 by [hidden email]: Pretty print settings  
does not work for OBSystemBrowserAdaptor
http://code.google.com/p/pharo/issues/detail?id=4107

i understand, maybe setting should be modified in order to appear only when  
Browser is selected.
I put Alain in the loop.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 4107 by [hidden email]: Pretty print settings  
does not work for OBSystemBrowserAdaptor
http://code.google.com/p/pharo/issues/detail?id=4107

Or setting for refactoring should be moved in Code browsing.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 4107 by [hidden email]: Pretty print settings  
does not work for OBSystemBrowserAdaptor
http://code.google.com/p/pharo/issues/detail?id=4107

Or maybe we need to have a system with just one Browser?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 4107 by [hidden email]: Pretty print settings does  
not work for OBSystemBrowserAdaptor
http://code.google.com/p/pharo/issues/detail?id=4107

it is possible to set a precondition for a setting.
I can put one for the pretty print setting.
so that if the current browser class is not Browser then the setting is not  
shown.
is it ok like that ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 4107 by marianopeck: Pretty print settings does not  
work for OBSystemBrowserAdaptor
http://code.google.com/p/pharo/issues/detail?id=4107

for me it sounds good. that precondition is computed every time the  
settings browser is open ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 4107 by [hidden email]: Pretty print settings does  
not work for OBSystemBrowserAdaptor
http://code.google.com/p/pharo/issues/detail?id=4107

yes

btw: OB browser has its own setting for pretty printing, which is  
AutoFormatOnDisplay I guess and I don't understand why OB does'nt make use  
of the default setting for that.
This would be cleaner  no ?



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 4107 by [hidden email]: Pretty print settings  
does not work for OBSystemBrowserAdaptor
http://code.google.com/p/pharo/issues/detail?id=4107

@markus yes maybe remove the old one :-)
@alain : can you modify to settings in order to use AutoFormatDisplay for  
OB ? This will simplify the settings.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 4107 by [hidden email]: Pretty print settings does  
not work for OBSystemBrowserAdaptor
http://code.google.com/p/pharo/issues/detail?id=4107

Hi Serge,

There is nothing to change in OB regarding AutoFormatDisplay, it works as  
expected.
Concerning the #browseWithPrettyPrint preference,
It seems to me that
'pretty print' is a better name, newbies will use this token to search for  
a setting for it and it is also used alsewhere (pretty print difference),  
and 'pretty print' is even used in the menu of the OB browser itself  
(not 'auto format').

A reason for OB to use its own setting could the portability of the package  
but
OB makes also use of the showAnnotationPane preference which is in the core.
Lukas ?





_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: MigratedToFogBugz

Comment #14 on issue 4107 by [hidden email]: Pretty print settings  
does not work for OBSystemBrowserAdaptor
http://code.google.com/p/pharo/issues/detail?id=4107#c14

Issue migrated to https://pharo.fogbugz.com/f/cases/4154

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker