Issue 4120 in pharo: CrLfFileStream needs to be moved to deprecated13

Status: Accepted
Owner: [hidden email]

New issue 4120 by [hidden email]: CrLfFileStream needs to be moved  
to deprecated13
http://code.google.com/p/pharo/issues/detail?id=4120

basicNew
        self deprecated: 'MultiByteFileStream should now be used for my  
functionality.'.

So CrLfFileStream needs to be moved to deprecated13 and all users need to  
be fixed.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 4120 by [hidden email]: CrLfFileStream needs to be  
moved to deprecated13
http://code.google.com/p/pharo/issues/detail?id=4120

No.
CRLFFileStream (the class) is kept for compatibility with external  
packages, VMMaker being one of them...

Only direct creation of new instances #using basicNew is deprecated.

#new already redirects to an appropriate MultiByteFileStream instance  
instead, so no new instances will be created.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4120 by [hidden email]: CrLfFileStream needs to  
be moved to deprecated13
http://code.google.com/p/pharo/issues/detail?id=4120

Then this should be documented.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4120 by [hidden email]: CrLfFileStream needs to  
be moved to deprecated13
http://code.google.com/p/pharo/issues/detail?id=4120

Nevertheless:

   -> need to refactor to not use CrLfFileStream
   -> put explanation in the deprecated method and check class comment



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed
        Labels: Milestone-1.3

Comment #4 on issue 4120 by [hidden email]: CrLfFileStream needs to  
be moved to deprecated13
http://code.google.com/p/pharo/issues/detail?id=4120

The attached changeset

   -> rewrite all clients
   -> moves the class to a new "Compatibility" Package

Please execute as a postscript:

     Smalltalk removeFromStartUpList: CrLfFileStream.

additional trivial cleanup: remove #ifClassOrganizerDo: (unused and empty)

Attachments:
        CleanCrLfFileStream.1.cs  5.0 KB
        RemoveIfClassOrganizerDo.1.cs  147 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker