Issue 4126 in pharo: Speeding up HelpBrowser by 50%

Status: Accepted
Owner: [hidden email]
CC: marianopeck
Labels: Importance-High Difficulty-Easy

New issue 4126 by [hidden email]: Speeding up HelpBrowser by 50%
http://code.google.com/p/pharo/issues/detail?id=4126

Mariano said:
MessageTally time: [HelpBrowser open]   between 2 seconds in Cog and with a  
regular VM between 6 and 8....
is there an easy way to improve it ?

Here is my answer:
SystemHelp>>allSystemHelpPragmas takes time. When you open a browser, the  
method HelpBrowser>>open is called once and  
SystemHelp>>allSystemHelpPragmas twice. Easy to suspect that a cache is  
missing.

So, if you define
-=-=-=-=-=-=-=-=-=
HelpBrowser>>helpTopic
        ^ helpTopicCache ifNil: [ helpTopicCache := rootTopic asHelpTopic ]
-=-=-=-=-=-=-=-=-=

and adapt HelpBrowser>>refresh you win 50% of execution time.

Before this fix, I have:
[HelpBrowser open] timeToRun
=> 6099

After the fix I have:
[HelpBrowser open] timeToRun
=> 3094

Naturally, tests are kept green.

Attachments:
        HelpBrowserFix.1.cs  998 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed
        Labels: Milestone-1.3

Comment #1 on issue 4126 by [hidden email]: Speeding up HelpBrowser  
by 50%
http://code.google.com/p/pharo/issues/detail?id=4126

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #2 on issue 4126 by [hidden email]: Speeding up HelpBrowser  
by 50%
http://code.google.com/p/pharo/issues/detail?id=4126

in 13177


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker