Issue 4146 in pharo: Monticello refactoring

Status: New
Owner: ----

New issue 4146 by [hidden email]: Monticello refactoring
http://code.google.com/p/pharo/issues/detail?id=4146

Pharo1.3a
Latest update: #13173

MCRepositoryInspector>>#versionSelection: is missing the message "changed:  
#hasVersion", version := nil

MCRepositoryInspector>>#versionSelection: is missing "self  
versionSelection: 0"

Maybe the code should be moved to MCVersionInspector.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 4146 by [hidden email]: Monticello refactoring
http://code.google.com/p/pharo/issues/detail?id=4146

add the code so that we can see and integrate it.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4146 by [hidden email]: Monticello  
refactoring
http://code.google.com/p/pharo/issues/detail?id=4146

Here is what I think it should look like:

MCRepositoryInspector>>#packageSelection: aNumber
        selectedPackage := aNumber isZero ifFalse: [ packages at: aNumber ].
        self versionSelection: 0.
        versions := repository versionsAvailableForPackage: selectedPackage.
        self changed: #packageSelection; changed: #versionList


MCRepositoryInspector>>#versionSelection: aNumber
        aNumber isZero
                ifTrue: [ version := selectedVersion := nil ]
                ifFalse: [
                        selectedVersion := versions at: aNumber].
        self changed: #versionSelection; changed: #summary; changed: #hasVersion



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4146 by [hidden email]: Monticello refactoring
http://code.google.com/p/pharo/issues/detail?id=4146

Issue 4147 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed

Comment #4 on issue 4146 by marianopeck: Monticello refactoring
http://code.google.com/p/pharo/issues/detail?id=4146

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-1.3

Comment #5 on issue 4146 by [hidden email]: Monticello refactoring
http://code.google.com/p/pharo/issues/detail?id=4146

I will have a look at that.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 4146 by [hidden email]: Monticello refactoring
http://code.google.com/p/pharo/issues/detail?id=4146

It would really really really help if people would attach *machine  
readable* code to bug reports. It's amazing just how much energy it costs  
to do this... if this report would have machine readable (.cs or SLICE)  
code attached, it would have been harvested weeks ago.

In addition, this bug report does fail to explain the context of the  
change. I honestly don't get it at all.
What is the problem? Why is the solution a solution?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Comment
        Labels: -Milestone-1.3

Comment #7 on issue 4146 by [hidden email]: Monticello refactoring
http://code.google.com/p/pharo/issues/detail?id=4146

As such, I de-tag it to not be a show stopper for 1.3


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 4146 by [hidden email]: Monticello  
refactoring
http://code.google.com/p/pharo/issues/detail?id=4146

Hi,

as for the description of the kind of error, please excuse my too short  
descripion.

As MCRepositoryInspector is not used (MCFileRepositoryInspector is), this  
code is broken. The users of this class are MCGOODSRepository and  
MCMagmaRepository, both which are not part of Core or Dev image.

As for the requirements for proposed fixes: I was not aware of such a  
requirement for proposed fixes. Neither the issue template (which gives a  
basic hint) nor the page  
http://www.pharo-project.org/community/issue-tracking mention that fixes  
are only recognized using changesets or slices. The first few results  
that "da google" yields for monticello slices are not really straight  
forward. Please add a link/ short howto to the bug report howto.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 4146 by [hidden email]: Monticello refactoring
http://code.google.com/p/pharo/issues/detail?id=4146

normally I should merge the changes made by chris mueller in squeak but  
busy.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 4146 by [hidden email]: Monticello refactoring
http://code.google.com/p/pharo/issues/detail?id=4146

This link may help you and us in a similar way.

http://code.google.com/p/pharo/wiki/HowToContribute

I'm trying to understand what you propose.
Attaching a cs can help us.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #11 on issue 4146 by [hidden email]: Monticello refactoring
http://code.google.com/p/pharo/issues/detail?id=4146

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Invalid

Comment #12 on issue 4146 by [hidden email]: Monticello refactoring
http://code.google.com/p/pharo/issues/detail?id=4146

as no code was ever submitted, I close this (because the report has just  
not enough information to be understandable)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 4146 by [hidden email]: Monticello refactoring
http://code.google.com/p/pharo/issues/detail?id=4146

Comment #2 has the code.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker