Issue 4153 in pharo: add temp does not add the temp in

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 4153 in pharo: add temp does not add the temp in

pharo
Status: Accepted
Owner: marianopeck
CC: renggli,  [hidden email]
Labels: Milestone-1.3

New issue 4153 by marianopeck: add temp does not add the temp in
http://code.google.com/p/pharo/issues/detail?id=4153

when the system asks me to add
if I want to add a temp, the temp does not show up.

Pharo image: Pharo 1.3
Pharo core version: 1.3 13179


Steps to reproduce:
1.  Just create a method like this:
methodBlah
a := 'aaaa'.
2. When the popup ask, choose temp.
3. The temp is not created.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4153 in pharo: add temp does not add the temp in

pharo
Updates:
        Status: FixProposed
        Cc: [hidden email]

Comment #1 on issue 4153 by marianopeck: add temp does not add the temp in
http://code.google.com/p/pharo/issues/detail?id=4153

Lukas did a fix, I put a slice in inbox:


Name: SLICE-Issue-4153-AddTempDoesNotAddTemp-MarianoMartinezPeck.1
Author: MarianoMartinezPeck
Time: 10 May 2011, 8:58:09 pm
UUID: 0cd65a78-dc3c-48ef-9a2a-6d4275a16117
Ancestors:
Dependencies: Traits-MarianoMartinezPeck.391

Fix to issue 4153. Thanks Lukas


However, he said: I can reproduce it everywhere, in Pharo 1.2 and 1.3. I  
don't think it
has anything to do with Shout or eCompletion. It looks like the
problem is that the new text editor that doesn't consequently reuse
the same Text object but instead creates new ones. The method
#compile:classified:withStamp:notifying:logSource: depends on the fact
that this is always the same Text instance, even after editing.
Luckily we can fix that easily, but there might be other subtle bugs
lingering around.


Andrian: can you check if there could be more places like Lukas mention?



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4153 in pharo: add temp does not add the temp in

pharo
Updates:
        Labels: Milestone-1.2.2 Importance-High

Comment #2 on issue 4153 by renggli: add temp does not add the temp in
http://code.google.com/p/pharo/issues/detail?id=4153

Could this be fixed primarily in Pharo 1.2? I think this is super important  
if Pharo 1.2 should be adopted.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4153 in pharo: add temp does not add the temp in

pharo

Comment #3 on issue 4153 by marianopeck: add temp does not add the temp in
http://code.google.com/p/pharo/issues/detail?id=4153

Lukas, I don't know how, but in 1.2.1 this is fixed. Probably any another  
way. I have no idea. I just know that it works.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4153 in pharo: add temp does not add the temp in

pharo

Comment #4 on issue 4153 by [hidden email]: add temp does not add  
the temp in
http://code.google.com/p/pharo/issues/detail?id=4153

in 13188

TODO: Check 1.2


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4153 in pharo: add temp does not add the temp in

pharo
Updates:
        Status: Closed

Comment #5 on issue 4153 by [hidden email]: add temp does not add  
the temp in
http://code.google.com/p/pharo/issues/detail?id=4153

I added that change to 1.2, too.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4153 in pharo: add temp does not add the temp in

pharo

Comment #6 on issue 4153 by renggli: add temp does not add the temp in
http://code.google.com/p/pharo/issues/detail?id=4153

Great news, thanks a lot! :-)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker