Issue 4157 in pharo: TextColor is ignored in large TextEditors

Status: Accepted
Owner: renggli
Labels: Type-ReportDefect Milestone-1.2.2

New issue 4157 by renggli: TextColor is ignored in large TextEditors
http://code.google.com/p/pharo/issues/detail?id=4157

See attached screenshot: it works for the small method (right), but if the  
amount of text is larger coloring is ignored.

Attachments:
        Screen shot 2011-05-03 at 19.31.47 .png  74.5 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #1 on issue 4157 by [hidden email]: TextColor is ignored in  
large TextEditors
http://code.google.com/p/pharo/issues/detail?id=4157

Thanks lukas. Indeed what a strange bug. Alain I know that you are busy,  
but one day for relaxing this is a fun bug.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-1.3

Comment #2 on issue 4157 by [hidden email]: TextColor is ignored in  
large TextEditors
http://code.google.com/p/pharo/issues/detail?id=4157

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-1.2.2

Comment #3 on issue 4157 by [hidden email]: TextColor is ignored in  
large TextEditors
http://code.google.com/p/pharo/issues/detail?id=4157

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4157 by [hidden email]: TextColor is ignored in  
large TextEditors
http://code.google.com/p/pharo/issues/detail?id=4157

Lukas, I can't reproduce it with a 1.3.
I've used a workspace with the 'welcome to Pharo' content that I have copy  
and paste a lot of times. At the end, 3 mb of text saved in a text file.
If I open back this file in a shout workspace, then the text color is still  
ok.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 4157 by renggli: TextColor is ignored in large  
TextEditors
http://code.google.com/p/pharo/issues/detail?id=4157

Compare the package JQuery-Core-lr.116 with the previous version (see  
screenshot), or look at the methods in the browser. Same problem  
everyhwere, formatting is ignored.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 4157 by [hidden email]: TextColor is ignored in  
large TextEditors
http://code.google.com/p/pharo/issues/detail?id=4157

resolved.
It comes from NullTextStyler which is used by the PluggableTextMorph of the  
patch browser.
As far as I understand, NullTextStyler is supposed to not format text.
So, NullTextStyler>>#styleInBackgroundProcess:  should do nothing (sent  
when text length > 4096)
as it is for NullTextStyler>>#style:


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed
        Labels: Milestone-1.2.2

Comment #7 on issue 4157 by [hidden email]: TextColor is ignored in  
large TextEditors
http://code.google.com/p/pharo/issues/detail?id=4157

btw, I've cleaned NullTextStyler (unused methods deprecation).

For 1.3:
SLICE-Issue-4157-TextColor-is-ignored-in-large-TextEditors

For 1.2
a .cs is attached

Lukas, do you confirm it is ok ?


Attachments:
        4157-TextColor-is-ignored-in-large-TextEditors.2.cs  2.7 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 4157 by [hidden email]: TextColor is ignored in  
large TextEditors
http://code.google.com/p/pharo/issues/detail?id=4157

in 13189

TODO: 1.2


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #9 on issue 4157 by [hidden email]: TextColor is ignored in  
large TextEditors
http://code.google.com/p/pharo/issues/detail?id=4157

in 12352


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 4157 by [hidden email]: TextColor is ignored in  
large TextEditors
http://code.google.com/p/pharo/issues/detail?id=4157

IIRC, this was made on purpose to avoid waiting hours for syntax
highlighting to color big regions.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker