Issue 4159 in pharo: "Method Source with it" DNU #asNode

Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.3-DevImage Importance-High

New issue 4159 by [hidden email]: "Method Source with it" DNU #asNode
http://code.google.com/p/pharo/issues/detail?id=4159

When one does a full text search on 1.3 Full.

==> DNU  #asNode


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Type-OB

Comment #1 on issue 4159 by [hidden email]: "Method Source with it"  
DNU #asNode
http://code.google.com/p/pharo/issues/detail?id=4159

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: renggli

Comment #2 on issue 4159 by [hidden email]: "Method Source with it"  
DNU #asNode
http://code.google.com/p/pharo/issues/detail?id=4159

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4159 by renggli: "Method Source with it" DNU #asNode
http://code.google.com/p/pharo/issues/detail?id=4159

How do you do that? Press Ctrl+Shift+E?

It works for me. Stacktrace?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4159 by marianopeck: "Method Source with it" DNU #asNode
http://code.google.com/p/pharo/issues/detail?id=4159

For me it happens just sometimes, not always. I will try to get the  
stackstace next time it happens. I think it could be related to the changes  
in the MethodReference and MethodReferenceWithSources, etc


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed

Comment #5 on issue 4159 by marianopeck: "Method Source with it" DNU #asNode
http://code.google.com/p/pharo/issues/detail?id=4159

I found the problem. It is what I was suspecting, the refactor in  
MethodReference and friends. The problem is that:

DEVToolSet class >> browseMessageSet: messageList name: title autoSelect:  
autoSelectString
        "Would be better to open an OBImplementorsBrowser or an OBSendersBrowser,  
but ToolSet does not make any difference between senders and implementors.  
It may be possible to use the title parameter to guess if it's senders or  
implementors but then, what do you do with the messageList variable?"
       
        | mrefList |
       
        self flag: #mref. "Compatibility with pre-MethodReference lists."
        mrefList := (MessageSet messageList: messageList) messageList.
       
        ^ OBMethodListBrowser
                browseRoot: (OBCollectionNode on: (mrefList collect: [:methodRef |  
methodRef asNode]))
                title: title



is doing "methodRef" asNode. But, methodRef variable can in fact be other  
thing that MethodRefernece, like for example, CommentReference.  So  
implementing

CommentReference >> asNode
        ^ OBMethodNode on: self

Fix the problem.  However, I would take advantage of the hierrachy and  
maybe put it only once in SourceReference, so that it works for  
CommentReference, MethodReference, SourcedMethodReference, etc.

Anyway, I attach PharoDebug.log

Cheers

Attachments:
        PharoDebug.log  36.1 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: -renggli

Comment #6 on issue 4159 by renggli: "Method Source with it" DNU #asNode
http://code.google.com/p/pharo/issues/detail?id=4159

I don't have that code in my image. Neither OBMethodListBrowser nor a  
method called #browseMessageSet:name:autoSelect: are part of OB.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email] [hidden email]

Comment #7 on issue 4159 by marianopeck: "Method Source with it" DNU #asNode
http://code.google.com/p/pharo/issues/detail?id=4159

Wow...this is sooooo weird. The class OBMethodListBrowser is in the package  
ImageForDevelopers!!!

I don't understand what happened, why that class, why in that package. It  
seems it is even from Pharo 1.2.

Anyway, implementing asNode in CommentReference or SourceReference fixes  
the problem, regardless where the OBMethodListBrowser and  
#browseMessageSet:name:autoSelect: are.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 4159 by [hidden email]: "Method Source with it" DNU  
#asNode
http://code.google.com/p/pharo/issues/detail?id=4159

In my 1.2.1 image, SourceReference>>asNode implements exactly that and it's  
in the OB-Standard package

so.... what happened?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #9 on issue 4159 by marianopeck: "Method Source with it" DNU #asNode
http://code.google.com/p/pharo/issues/detail?id=4159

I guess it happens what happens always:

1) we do changes in PharoOB.
2) when we are for realasing, PharoOB doesn't work. Nobody knows how to fix  
it. Nobody want to merge. So:
3) we copy all versions from Lukas OB to PharoOB. Then we release.
4) we loose all our changes.

As simple as that. Be aware than can be more changes to PharoOB that we  
lost.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 4159 by [hidden email]: "Method Source with it"  
DNU #asNode
http://code.google.com/p/pharo/issues/detail?id=4159

Yes I already fixed that long time ago. :(


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: renggli

Comment #11 on issue 4159 by marianopeck: "Method Source with it" DNU  
#asNode
http://code.google.com/p/pharo/issues/detail?id=4159

Lukas could you integrate this to your OB (so that merge is easier for us):

CommentReference>>asNode
        ^ OBClassCommentNode on: class

Thanks


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 4159 by renggli: "Method Source with it" DNU #asNode
http://code.google.com/p/pharo/issues/detail?id=4159

Added, and thanks for writing the test of the unused code.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 4159 by marianopeck: "Method Source with it" DNU  
#asNode
http://code.google.com/p/pharo/issues/detail?id=4159

thanks Lukas. "the test of the unused code" ?? mmmmm I didn't understand.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #14 on issue 4159 by renggli: "Method Source with it" DNU #asNode
http://code.google.com/p/pharo/issues/detail?id=4159

CommentReference>>asNode is not used by the code it is defined (which is  
bad ), and it is not tested (which is worse), thus it will eventually break.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #15 on issue 4159 by [hidden email]: "Method Source with it"  
DNU #asNode
http://code.google.com/p/pharo/issues/detail?id=4159

shouldn't we just remove OBMethodListBrowser from ImageForDevelopers? (and  
fix the sender?)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #16 on issue 4159 by renggli: "Method Source with it" DNU #asNode
http://code.google.com/p/pharo/issues/detail?id=4159

Or mabye integrate OBMethodListBrowser into OB-Standard together with the  
tests it comes along? Are there packages that I can merge?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #17 on issue 4159 by marianopeck: "Method Source with it" DNU  
#asNode
http://code.google.com/p/pharo/issues/detail?id=4159

I have no idea what OBMethodListBrowser is, who put it there, why, how to  
fix it. Nothing. I don't know anything about this. Maybe we can ask in the  
mailing list the reasons of why this class is there...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #18 on issue 4159 by [hidden email]: "Method Source with it"  
DNU #asNode
http://code.google.com/p/pharo/issues/detail?id=4159

Then just remove OBMethodListBrowser seems to be the easiest thing to do.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #19 on issue 4159 by [hidden email]: "Method Source with it"  
DNU #asNode
http://code.google.com/p/pharo/issues/detail?id=4159

can we close this issue?




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker