Issue 4160 in pharo: HelpSystem is Dirty in Fulll

Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.3-DevImage

New issue 4160 by [hidden email]: HelpSystem is Dirty in Fulll
http://code.google.com/p/pharo/issues/detail?id=4160


-> There is a package HelpSystem loaded, even though this is in Core.
        (CongfigurationOfHelpSystem)

-> The version loaded is a different one than in Core

-> Package Shortcuts-Help overrides a class that is in the HelpSystem of  
Core


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #1 on issue 4160 by marianopeck: HelpSystem is Dirty in Fulll
http://code.google.com/p/pharo/issues/detail?id=4160

mmm I think this is because Metacello loads it.... I should check


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4160 by [hidden email]: HelpSystem is Dirty in  
Fulll
http://code.google.com/p/pharo/issues/detail?id=4160

HelpSystem should not be loaded since it is already included in the core  
distribution.
It is maintained WITH Pharo and in the usual Pharo repository.

The "HelpSystem-Core" from squeaksource.com/HelpSystem is for Squeak and  
Pharo and currently not maintained.

So the ConfigurationOfPharo should only load "book packages" (like  
Smalltalk-Help or Pharo-Project-Help package) from  
squeaksource.com/HelpSystem but NOT the Core package.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4160 by marianopeck: HelpSystem is Dirty in Fulll
http://code.google.com/p/pharo/issues/detail?id=4160

Weeks ago I send an email to Dale. I am waiting his answer. I copy paste it  
here




Hi Dale. I hope you are enjoying your holidays. Logically, 'Metacello-Help'  
is defined as:

package: 'Metacello-Help' with: [
                 spec requires: 'Help System'. ];


However, HelpSystem is integrated in PharoCore (not via  
ConfigurationOfHelpSystem). Hence, when I load 'Metacello-Help' in a  
PharoCore, Metacello loads HelpSystem with ConfigurationOfHelp, bringing a  
new version and marking the package HelpSystem as dirty.

 From ConfigurationOfPharo, I have this:

     project: 'Metacello'
                     with:
                         [ spec
                                 className: 'ConfigurationOfMetacello';
                                 file: 'ConfigurationOfMetacello';
                                 loads:  
#('Metacello-Core' 'Tutorial' 'UI' 'Metacello-ProfStef' 'Metacello-Help');
                                 
repository: 'http://www.squeaksource.com/MetacelloRepository' ];

So...any idea how can I get 'Metacello-Help' without the HelpSystem ?

A way I see is remove 'Metacello-Help' from the previous lines and instead  
adding a line:

package: 'Metacello-Help' with: [ spec  
repository: 'http://www.squeaksource.com/metacello' ];

so that to bypass Metacello ;)

Ahh BTW; this is issue: http://code.google.com/p/pharo/issues/detail?id=4160



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4160 by [hidden email]: HelpSystem is Dirty in  
Fulll
http://code.google.com/p/pharo/issues/detail?id=4160

But
   package: 'Metacello-Help' with: [spec requires: 'Help System'. ];

is not correct since HelpSystem is integrated into Pharo core and there
is no specific #requires: for what is included in "Core"
Otherwise you would have to write

   package: 'Metacello-Help' with: [
        spec requires: 'Help System';
             requires: 'Kernel-Collections';
             ...
  ];


So I think it is valid to load it like a usual package.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 4160 by marianopeck: HelpSystem is Dirty in Fulll
http://code.google.com/p/pharo/issues/detail?id=4160

Yes Torsten that #requires doesn't make sense in PHARO. But  
ConfigurationOfMetacello loads also in Gemstone and Squeak where HelpSystem  
may not be present. So, we can load it as a normal package for the moment.  
Then maybe Dale can update ConfigurationOfMetacello so that it only adds  
the #required for Gemstone/Squeak but not for Pharo.

I will load the package individually for the moment. And then if Dale  
updates it we change it again.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 4160 by marianopeck: HelpSystem is Dirty in Fulll
http://code.google.com/p/pharo/issues/detail?id=4160

I am following this issue with Dale in  
http://code.google.com/p/metacello/issues/detail?id=139.  I have proposed a  
fix but I am waiting for him.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 4160 by [hidden email]: HelpSystem is Dirty in  
Fulll
http://code.google.com/p/pharo/issues/detail?id=4160

The reason it is dirty is that I added ShortcutsHelp to help-core (just to  
not have a package with one class)
But Pharo-Help seems to be the right place to put it...

So we need to

a) remove ShortcutsHelp from Core (I will do that)
b) commit ShortcutsHelp to the Pharo Help Package


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 4160 by [hidden email]: HelpSystem is Dirty in  
Fulll
http://code.google.com/p/pharo/issues/detail?id=4160

Oh, Dev load ShortcutsHelp *again* (as a one-class package). That's why  
it's dirty!

So we need to add:

C) Should not load ShortcutsHelp package.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 4160 by [hidden email]: HelpSystem is Dirty in  
Fulll
http://code.google.com/p/pharo/issues/detail?id=4160

(Ceterum Censo... we burn too much time maintaining Core and  Dev as  
different artefacts)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-1.3-DevImage Milestone-1.3

Comment #10 on issue 4160 by [hidden email]: HelpSystem is Dirty in  
Fulll
http://code.google.com/p/pharo/issues/detail?id=4160

So for now the thing to do is just: Remove ShortcutsHelp from Core.

Cleanung up dev and simplifying the loaded packages is another thing to  
do...

So I categorize this as Core and remove ShortcutsHelp from Core.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #11 on issue 4160 by [hidden email]: HelpSystem is Dirty in  
Fulll
http://code.google.com/p/pharo/issues/detail?id=4160

I removed ShortcutsHelp from Core


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker