Issue 4167 in pharo: Parentheses, brackets, square brackets are not correctly undoed sometimes

Status: Accepted
Owner: [hidden email]

New issue 4167 by [hidden email]: Parentheses, brackets, square  
brackets are not correctly undoed sometimes
http://code.google.com/p/pharo/issues/detail?id=4167

sometimes, I type [ and it writes the corresponding ]

if I do ctrl+z it just deletes the [, not the ]

---------------------------------

if you select some code and type the ( to wrap the selection, then the undo  
does not undo the parentheses either :(

It happens in pharo 1.2 and 1.3


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: renggli [hidden email]

Comment #1 on issue 4167 by marianopeck: Parentheses, brackets, square  
brackets are not correctly undoed sometimes
http://code.google.com/p/pharo/issues/detail?id=4167

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed
        Owner: renggli
        Cc: -renggli [hidden email]
        Labels: Milestone-1.2.2 Type-OB

Comment #2 on issue 4167 by renggli: Parentheses, brackets, square brackets  
are not correctly undoed sometimes
http://code.google.com/p/pharo/issues/detail?id=4167

Name: ECompletion-lr.143
Author: lr
Time: 8 May 2011, 5:16:27 pm
UUID: 30471652-dbb6-47a5-a096-e42b5074809d
Ancestors: ECompletion-lr.142

- fix undo/redo of smart characters and completion action


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #3 on issue 4167 by marianopeck: Parentheses, brackets, square  
brackets are not correctly undoed sometimes
http://code.google.com/p/pharo/issues/detail?id=4167

Thanks Lukas. Since we do not directly use ECompletion but instead  
OCompletion, and OCompletion seems to have its own version of ECompletion,  
we should merge your changes in OCompletion fork. Is this correct?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4167 by renggli: Parentheses, brackets, square brackets  
are not correctly undoed sometimes
http://code.google.com/p/pharo/issues/detail?id=4167

I don't know. It looked like the way eCompletion modified the text editor  
never took undo/redo into account (also not with the old editor).


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 4167 by [hidden email]: Parentheses, brackets,  
square brackets are not correctly undoed sometimes
http://code.google.com/p/pharo/issues/detail?id=4167

Merging the changes should work.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker