Issue 4170 in pharo: AbstractTool references non-existing DialogGroupAdder

Status: Accepted
Owner: [hidden email]
CC: [hidden email]
Labels: Milestone-1.3

New issue 4170 by [hidden email]: AbstractTool references  
non-existing DialogGroupAdder
http://code.google.com/p/pharo/issues/detail?id=4170

AbstractTool references non-existing DialogGroupAdder


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Comment

Comment #1 on issue 4170 by [hidden email]: AbstractTool references  
non-existing DialogGroupAdder
http://code.google.com/p/pharo/issues/detail?id=4170

So do we integrate groups as a basic tool (used by Nautilus, TestRunner,  
Monticello etc by example) or do we removed groups methods from  
AbstractTool ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4170 by [hidden email]: AbstractTool references  
non-existing DialogGroupAdder
http://code.google.com/p/pharo/issues/detail?id=4170

What is clear is that we can not reference a non-existing class in the core  
image.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed

Comment #3 on issue 4170 by [hidden email]: AbstractTool references  
non-existing DialogGroupAdder
http://code.google.com/p/pharo/issues/detail?id=4170

The problem is that having this undeclared ref now "shadows" any other  
newly introduced undeclalreds
(we would see it directly if the test start failing).

So we can not (no way) have references to non-exisiting classes in the code  
base.

Both methods are not called, so you can just put them as extensions in your  
package.

I added a change to remove the methods.

Attachments:
        FixUndeclared.1.cs  193 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #4 on issue 4170 by marianopeck: AbstractTool references  
non-existing DialogGroupAdder
http://code.google.com/p/pharo/issues/detail?id=4170

Thanks Marcus. It happened exactly what you describe. It should be removed  
from core and put as extenions in the package that use them.
I change the status to FixToInclude


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #5 on issue 4170 by [hidden email]: AbstractTool references  
non-existing DialogGroupAdder
http://code.google.com/p/pharo/issues/detail?id=4170

in 13199


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker