Issue 4177 in pharo: New TranscriptWindow and several fixes to the (new) Transcript adoption

Status: Accepted
Owner: [hidden email]

New issue 4177 by [hidden email]: New TranscriptWindow and several  
fixes to the (new) Transcript adoption
http://code.google.com/p/pharo/issues/detail?id=4177

If you fill an issue for the first time, please read "How to report bugs"
at http://www.pharo-project.org/community/issue-tracking

Pharo image: <core, dev or web>
Pharo core version: <copy from World/System/About>
Virtual machine used: <ex: pharo-vm-0.15.2f-linux>
Class browser used if applicable: <ex: O2PackageBrowserAdaptor. If you
don't
know, print "SystemBrowser default">

Steps to reproduce:
1.
2.
3.


Paste or attach stack trace if applicable (look at the file PharoDebug.log
located in the same directory as your image):



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 4177 by [hidden email]: New TranscriptWindow and  
several fixes to the (new) Transcript adoption
http://code.google.com/p/pharo/issues/detail?id=4177

Issue 3112 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4177 by [hidden email]: New TranscriptWindow and  
several fixes to the (new) Transcript adoption
http://code.google.com/p/pharo/issues/detail?id=4177

Issue 4093 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4177 by [hidden email]: New TranscriptWindow and  
several fixes to the (new) Transcript adoption
http://code.google.com/p/pharo/issues/detail?id=4177

Issue 4067 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4177 by [hidden email]: New TranscriptWindow and  
several fixes to the (new) Transcript adoption
http://code.google.com/p/pharo/issues/detail?id=4177

Issue 4039 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-1.3

Comment #5 on issue 4177 by [hidden email]: New TranscriptWindow and  
several fixes to the (new) Transcript adoption
http://code.google.com/p/pharo/issues/detail?id=4177

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 4177 by [hidden email]: New TranscriptWindow and  
several fixes to the (new) Transcript adoption
http://code.google.com/p/pharo/issues/detail?id=4177

Issue 4023 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 4177 by [hidden email]: New TranscriptWindow and  
several fixes to the (new) Transcript adoption
http://code.google.com/p/pharo/issues/detail?id=4177

Issue 4116 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 4177 by [hidden email]: New TranscriptWindow and  
several fixes to the (new) Transcript adoption
http://code.google.com/p/pharo/issues/detail?id=4177

Fixed all issues related to the Transcript, now you can choose between the  
super fast read only transcript, or a writable one using a pluggable text  
morph.

3112: ThreadSafeTranscript >> #endEntry is Morphic dependent.
3948: Transcript and ThreadedTranscript needs to be merged.
4023:'Transcript clear' prints 'Transcript' after clearing prior text.
4039: To open ThreadSafeTranscript .
4067: Transcript does not work with system fonts (Win XP)  
(TranscriptModel>>displayOn: aForm uses StandardFonts now)
4093: alt_t (fixed by loading the post load: send  
initializeDesktopCommandSelectors for the worlds)
4116: minimizing, then output to transcript: redraw problems.

Please load also the postLoad.st, after loading the changeset.




Attachments:
        TranscriptCleanupAndWindowEnhancements.4.cs  30.6 KB
        PostLoad.st  402 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed

Comment #9 on issue 4177 by [hidden email]: New TranscriptWindow and  
several fixes to the (new) Transcript adoption
http://code.google.com/p/pharo/issues/detail?id=4177

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 4177 by [hidden email]: New TranscriptWindow  
and several fixes to the (new) Transcript adoption
http://code.google.com/p/pharo/issues/detail?id=4177

Issue 4024 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #11 on issue 4177 by [hidden email]: New TranscriptWindow  
and several fixes to the (new) Transcript adoption
http://code.google.com/p/pharo/issues/detail?id=4177

Issue 3948 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 4177 by [hidden email]: New TranscriptWindow  
and several fixes to the (new) Transcript adoption
http://code.google.com/p/pharo/issues/detail?id=4177

fernando
I do not undersand I thought that you introduced findATranscript: in  
pasteUp because you change code to use it
but now I see that it is deprecated.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 4177 by [hidden email]: New TranscriptWindow  
and several fixes to the (new) Transcript adoption
http://code.google.com/p/pharo/issues/detail?id=4177

But I integrated your changes in 13188 and the new transcript is cool :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #14 on issue 4177 by [hidden email]: New TranscriptWindow  
and several fixes to the (new) Transcript adoption
http://code.google.com/p/pharo/issues/detail?id=4177

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #15 on issue 4177 by [hidden email]: New TranscriptWindow  
and several fixes to the (new) Transcript adoption
http://code.google.com/p/pharo/issues/detail?id=4177

I will probably rollback the changes if I do not understand why the  
scriptLoader does not update the version number. Because I'm dead tired.
What is really strange is that the right updateXXX method is created, the  
right cs with the right number is created on the disc but after update when  
the SystemVersion is one less than expected.
May be there is an attempt to write something the old transcript, which  
leads to the obsolete reference which leads that the SystemVersion is not  
incremented but I doubt.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #16 on issue 4177 by [hidden email]: New TranscriptWindow  
and several fixes to the (new) Transcript adoption
http://code.google.com/p/pharo/issues/detail?id=4177

was the message


13188
-----

- Issue 4177: New TranscriptWindow and several fixes to the (new)  
Transcript adoption. Thanks a lot Fernando Olivero.
        3112: ThreadSafeTranscript >> #endEntry is Morphic dependent.
        3948: Transcript and ThreadedTranscript needs to be merged.
        4023: Transcript clear prints Transcript after clearing prior text.
        4039: To open ThreadSafeTranscript .
        4067: Transcript does not work with system fonts (Win XP)
(TranscriptModel>>displayOn: aForm uses StandardFonts now)
        4093: alt_t (fixed by loading the post load: send
initializeDesktopCommandSelectors for the worlds)
        4116: minimizing, then output to transcript: redraw problems.

Big thanks to fernando
*** APPLAUS ***

You see guys trust works :)

Stef



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #17 on issue 4177 by [hidden email]: New TranscriptWindow  
and several fixes to the (new) Transcript adoption
http://code.google.com/p/pharo/issues/detail?id=4177

This was my new postScript



forNewTranscript

        | users |
        users := (Smalltalk at: #Transcript) allCallsOn.
        (Smalltalk at: #Transcript) removeFromSystem.
        Smalltalk globals at: #Transcript put: TranscriptModel new.
        users do:[:each| each methodClass recompile: each selector ].
        ( Smalltalk globals at:#Transcript ) show: 'Grettings from CUIS?';cr.
        PasteUpMorph allInstances do:[:each| each isWorldMorph ifTrue:[ each  
initializeDesktopCommandKeySelectors ] ].




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #18 on issue 4177 by [hidden email]: New TranscriptWindow  
and several fixes to the (new) Transcript adoption
http://code.google.com/p/pharo/issues/detail?id=4177

Yes this is what I thought. I will have to look more closely.

[| newStream |
newSet
                ifNotNil: [(aStream respondsTo: #converter:)
                                ifTrue: [newStream := aStream]
                                ifFalse: [newStream := MultiByteBinaryOrTextStream with: aStream  
contentsOfEntireFile.
                                        newStream reset].
                        self newChanges: newSet.
                        newStream setConverterForCode.
                        newStream fileInAnnouncing: 'Loading ' , newName , '...'.
                        Transcript cr; show: 'File ' , aName , ' successfully filed in to change  
set ' , newName].

                        ^^^^^

        the fileInProcess uses an old version of the transcript

Now I do not understand why the transcript does not understand cr. because  
it is part of its interface anyway.
So I will study the loading because this is a nice example.

Now the post load does not have the time to recompile all the methods.
        and I guess that the ChangeSet does not increment the update counter.
I payed attention to modify the postload script to avoid Transcript but to  
use
        Smalltalk globals at: #Transcript just to avoid to hold reference to the  
old one.
       
So may be I can add the change back and see how I can increment the number  
by hand.
But I imagine that it will not work with the NonInteractiver?
Now a question what happen with the non interactive mode if a debugger pop  
up? does it kill the image?

I will rollback the changes and go to bed. too tired.
Stef

Attachments:
        PharoDebug.log  33.0 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #19 on issue 4177 by [hidden email]: New TranscriptWindow  
and several fixes to the (new) Transcript adoption
http://code.google.com/p/pharo/issues/detail?id=4177

Ok I tried and if I remove the Transcript show in the method below and it  
works


newChangesFromStream: aStream named: aName
        "File in the code from the stream into a new change set whose
        name is derived from aName. Leave the 'current change set'
        unchanged. Return the new change set or nil on failure."

        | oldChanges newName newSet |
        oldChanges := ChangeSet current.
        PreviousSet := oldChanges name. "so a Bumper update can find it"
        newName := aName withoutPeriodSuffix.
        newSet := self basicNewChangeSet: newName.
        [ | newStream |newSet ifNotNil:[
                (aStream respondsTo: #converter:) ifFalse: [
                        newStream := MultiByteBinaryOrTextStream with: (aStream  
contentsOfEntireFile).
                        newStream reset.] ifTrue: [newStream := aStream].
                self newChanges: newSet.
                newStream setConverterForCode.
                newStream fileInAnnouncing: 'Loading ', newName, '...'.
                Transcript cr; show: 'File ', aName, ' successfully filed in to change  
set ', newName].
        aStream close] ensure: [self newChanges: oldChanges].
        PreviousSet := nil.
        ^ newSet


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker