Issue 4223 in pharo: NOt all test packages are being unload in #cleanUpForProduction

Status: Accepted
Owner: marianopeck
Labels: Milestone-1.3

New issue 4223 by marianopeck: NOt all test packages are being unload in  
#cleanUpForProduction
http://code.google.com/p/pharo/issues/detail?id=4223

In Pharo1.3 #cleanUpForProduction does not unload all Test packages.  
The "problem" is that the list of packages is hand written...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #1 on issue 4223 by marianopeck: NOt all test packages are being  
unload in #cleanUpForProduction
http://code.google.com/p/pharo/issues/detail?id=4223

The list is now

unloadTestPackages
         
#('Tests' 'CollectionsTests' 'CompilerTests' 'FreeTypeTests' 'Graphics-Tests' 'KernelTests' 'MorphicTests' 'MultilingualTests' 'NetworkTests' 'ToolsTest' 'Gofer-Tests' 'Announcements-Tests-Core' 'CompressionTests' 'HelpSystem-Tests' 'Multilingual-Tests' 'Regex-Tests-Core' 'HelpSystem-Tests'  'Balloon-Collections-Tests' 'Collections-Atomic-Tests' 'StratifiedProxy-Tests' 'Finder-Tests' 'Zinc-Tests')
                 do: [ :each | (MCPackage named: each) unload ].


Name:  
SLICE-Issue-4223-TestPackagesNotRemovedFromCleanings-MarianoMartinezPeck.1
Author: MarianoMartinezPeck
Time: 14 May 2011, 12:18:34 am
UUID: 656399e8-7ef2-4b6c-bcd1-46fcd0fc44c3
Ancestors:
Dependencies: SUnit-MarianoMartinezPeck.40133

Fix to issue 4223

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4223 by [hidden email]: NOt all test packages  
are being unload in #cleanUpForProduction
http://code.google.com/p/pharo/issues/detail?id=4223

ok but why not checking that classes are subclasses of TestCase?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4223 by marianopeck: NOt all test packages are being  
unload in #cleanUpForProduction
http://code.google.com/p/pharo/issues/detail?id=4223

For the moment, include this fix as it is. To improve it, we open another  
issue.

I am not sure if I want an automatic method. Maybe there is a subclass of  
TestCase that it is in the same package of the model. Even if we usually  
put them in a separate packge, it can happen. So unloading the whole  
package is not cool.

What I think is that we only need to update this method once every new  
pharo release (so....every 6 months?) and I take me 5 minutes to fix it.  
This way I am sure which packages I am unloading and I don't unlaod  
something important by mistake.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Summary: Not all test packages are being unload in #cleanUpForProduction

Comment #4 on issue 4223 by [hidden email]: Not all test packages  
are being unload in #cleanUpForProduction
http://code.google.com/p/pharo/issues/detail?id=4223

sure this was the idea. I always integrate fix first and think later :)



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #5 on issue 4223 by [hidden email]: Not all test packages  
are being unload in #cleanUpForProduction
http://code.google.com/p/pharo/issues/detail?id=4223

in 13199


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker