Issue 4261 in pharo: Fixed checksForSlips manipulating strings and pretending they are methodReferences....

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 4261 in pharo: Fixed checksForSlips manipulating strings and pretending they are methodReferences....

pharo
Status: FixToInclude
Owner: [hidden email]
Labels: Milestone-1.3

New issue 4261 by [hidden email]: Fixed checksForSlips manipulating  
strings and pretending they are methodReferences....
http://code.google.com/p/pharo/issues/detail?id=4261

Smalltalk is not about string manipulation but about objects!

Here is the right code that match with method comments

checkForSlips
        "Return a collection of method refs with possible debugging code in them."
        | slips |
        slips := OrderedCollection new.
        self changedClasses do:
                [:aClass |
                (self methodChangesAtClass: aClass name) associationsDo:
                                [:mAssoc | | method | (#(remove addedThenRemoved) includes: mAssoc  
value) ifFalse:
                                        [method := aClass compiledMethodAt: mAssoc key ifAbsent: [nil].
                                        method ifNotNil:
                                                [method hasReportableSlip
                                                        ifTrue: [ slips add: (aClass >> mAssoc key) methodReference ]]]]].
        ^ slips


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4261 in pharo: Fixed checksForSlips manipulating strings and pretending they are methodReferences....

pharo
Updates:
        Status: closed

Comment #1 on issue 4261 by [hidden email]: Fixed checksForSlips  
manipulating strings and pretending they are methodReferences....
http://code.google.com/p/pharo/issues/detail?id=4261

I'm crappy software so I create duplicates.....


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker