Issue 4267 in pharo: RPackage

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 4267 in pharo: RPackage

pharo
Status: Accepted
Owner: [hidden email]

New issue 4267 by [hidden email]: RPackage
http://code.google.com/p/pharo/issues/detail?id=4267

packageFromOrganizer: anRPackageOrganizer

        self flag: #cyrille. "If the organizer is not able to find the package of  
a method, it is surely because something went wrong at one point. I got  
into that situation when having RPackage listening to the system. So a  
solution I have for now (this is maybe not the best one), is to check if  
the method is registered in RPackage, and if it is not, simulate a  
addMethod event to update the organizer.
        Specific behavior in RPackageOrganizer >> systemMethodRemovedActionFrom: "
        self methodClass packages detect: [:each | each includesSelector: self  
selector ofClass: self methodClass ] ifNone: [
                |tmpTrait|
                tmpTrait := (self methodClass traitComposition traitProvidingSelector:  
self selector).

---------------

/!\ here, tmpTrait could be nil

---------------

                tmpTrait packages detect: [:aRPackage | (aRPackage includesSelector: self  
selector ofClass: tmpTrait ) ] ifNone: [
                        self flag: 'should not arrive there now'. self halt.
                        self category isNil ifTrue: [Error signal].
                        anRPackageOrganizer systemMethodAddedActionFrom: (AddedEvent
                                method: self
                                selector: self selector
                                protocol: self category
                                class: self methodClass) asSystemAnnouncement.
                        ].
                ].
        ^ anRPackageOrganizer packageDefiningOrExtendingMethod: self


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4267 in pharo: RPackage

pharo
Updates:
        Cc: [hidden email] [hidden email]

Comment #1 on issue 4267 by [hidden email]: RPackage
http://code.google.com/p/pharo/issues/detail?id=4267

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4267 in pharo: RPackage

pharo

Comment #2 on issue 4267 by [hidden email]: RPackage
http://code.google.com/p/pharo/issues/detail?id=4267

A temporary fix has been proposed which check if tmpTrait is nil or not.  
But there is still a problem since for me, when it hangs, it was because  
metaClassSelectors wasn't up to date


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4267 in pharo: RPackage

pharo

Comment #3 on issue 4267 by [hidden email]: RPackage
http://code.google.com/p/pharo/issues/detail?id=4267

cyrille ben do we close this one?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4267 in pharo: RPackage

pharo

Comment #4 on issue 4267 by [hidden email]: RPackage
http://code.google.com/p/pharo/issues/detail?id=4267

I'm looking to it. There is indeed still some 'halt' signaled when loading  
nautilus


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4267 in pharo: RPackage

pharo
Updates:
        Status:
        Owner: ---

Comment #5 on issue 4267 by [hidden email]: RPackage
http://code.google.com/p/pharo/issues/detail?id=4267

Fixed with the last development version. The problem was that the  
organnizer was not importing metaClass methods when a class was  
recategorized. Therefore those methods were registered nowhere. I added a  
test for that.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4267 in pharo: RPackage

pharo

Comment #6 on issue 4267 by [hidden email]: RPackage
http://code.google.com/p/pharo/issues/detail?id=4267

Cyrille, is that ok now ?
Can I close this entry ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4267 in pharo: RPackage

pharo
Updates:
        Status: Comment

Comment #7 on issue 4267 by [hidden email]: RPackage
http://code.google.com/p/pharo/issues/detail?id=4267

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4267 in pharo: RPackage

pharo

Comment #8 on issue 4267 by [hidden email]: RPackage
http://code.google.com/p/pharo/issues/detail?id=4267

Yes you can close it



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4267 in pharo: RPackage

pharo
Updates:
        Status: Closed

Comment #9 on issue 4267 by [hidden email]: RPackage
http://code.google.com/p/pharo/issues/detail?id=4267

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker