Issue 4291 in pharo: Choose color dialog modal does not work anymore

Status: Accepted
Owner: [hidden email]

New issue 4291 by [hidden email]: Choose color dialog modal does not  
work anymore
http://code.google.com/p/pharo/issues/detail?id=4291

Pharo image: core and dev
Pharo core version: <copy from World/System/About>

Evaluate:

UIManager default chooseColor: Color blue.
UIManager inform:'Should popup after closing window'.

The message pops up when the dialog is open, not after close.

Works in 1.2.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-1.3

Comment #1 on issue 4291 by [hidden email]: Choose color dialog  
modal does not work anymore
http://code.google.com/p/pharo/issues/detail?id=4291

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4291 by [hidden email]: Choose color dialog  
modal does not work anymore
http://code.google.com/p/pharo/issues/detail?id=4291

(No comment was entered for this change.)

Attachments:
        runModal.1.cs  1.9 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: closed

Comment #3 on issue 4291 by [hidden email]: Choose color dialog  
modal does not work anymore
http://code.google.com/p/pharo/issues/detail?id=4291

in 13254


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Comment

Comment #4 on issue 4291 by [hidden email]: Choose color dialog  
modal does not work anymore
http://code.google.com/p/pharo/issues/detail?id=4291

Not fixed (UIManager default chooseColor)...

Same for all modality from UIManager.
For some reason MorphicUIManager>>openModal: deliberately does not open  
modally any more!




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 4291 by [hidden email]: Choose color dialog  
modal does not work anymore
http://code.google.com/p/pharo/issues/detail?id=4291

Seems to be due to inclusion of TEasilyThemed trait (expected to be applied  
to a Morph subclass).

Changing #openModel: should fix (revert changes to UITheme in addition).  
Possible other problems may occur (since MorphicUIManager is *not* a Morph).

MorphicUIManager>>openModal: aSystemWindow
        "Open the given window at an available position with modality.
        Answer the system window."
       
        ^World openModal: aSystemWindow


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 4291 by [hidden email]: Choose color dialog  
modal does not work anymore
http://code.google.com/p/pharo/issues/detail?id=4291

thanks.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #7 on issue 4291 by [hidden email]: Choose color dialog  
modal does not work anymore
http://code.google.com/p/pharo/issues/detail?id=4291

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 4291 by [hidden email]: Choose color dialog  
modal does not work anymore
http://code.google.com/p/pharo/issues/detail?id=4291

Thanks gary we tried the several modal situations and they worked with our  
fixes. So this is good that you checked because this code is not easy.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #9 on issue 4291 by [hidden email]: Choose color dialog  
modal does not work anymore
http://code.google.com/p/pharo/issues/detail?id=4291

I added the change to #openModal to 13255


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker