Issue 4310 in pharo: Cleanup stdio ServerMode preference

Status: ReviewNeeded
Owner: [hidden email]
Labels: Milestone-1.3

New issue 4310 by [hidden email]: Cleanup stdio ServerMode preference
http://code.google.com/p/pharo/issues/detail?id=4310


So I vote for removing that preference.

It seems the code behind does nothing anyway.

-> EncodeAndDecodeStdioFiles is only set to true in initialize. No other  
use.

Attachments:
        CleanUpServerModeSetting.1.cs  1.7 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Type-Cleanup

Comment #1 on issue 4310 by [hidden email]: Cleanup stdio ServerMode  
preference
http://code.google.com/p/pharo/issues/detail?id=4310

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4310 by [hidden email]: Cleanup stdio ServerMode  
preference
http://code.google.com/p/pharo/issues/detail?id=4310

stdioStreamClass

        ^self encodeAndDecodeStdioFiles
                ifTrue: [ MultiByteFileStream ]
                ifFalse: [ StandardFileStream ]

so it is used?

encodeAndDecodeStdioFiles
       
        ^EncodeAndDecodeStdioFiles ifNil: [ true ]

stdioSettingOn: aBuilder

        <systemsettings>
        "we should put them under System"
       
        (aBuilder group: #Files)
                label: 'Files' translated;
                description: 'File settings' translated;
                with: [
                        (aBuilder setting: #encodeAndDecodeStdioFiles)
                                label: 'Server mode' translated;
                                target: FileStream;
                                description: 'If enabled, then the contents of stdin, stdout and stderr  
are encoded/decoded using the system default text converter' translated]


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4310 by [hidden email]: Cleanup stdio ServerMode  
preference
http://code.google.com/p/pharo/issues/detail?id=4310

But there is no other use... just that.

So why not just do what happens when encodeAndDecodeStdioFiles returns  
true? (Which it does)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #4 on issue 4310 by [hidden email]: Cleanup stdio ServerMode  
preference
http://code.google.com/p/pharo/issues/detail?id=4310

in 13229


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker