Issue 4315 in pharo: #findElementOrNil: should be replaced by #scanFor: and deprecated

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 4315 in pharo: #findElementOrNil: should be replaced by #scanFor: and deprecated

pharo
Status: Accepted
Owner: [hidden email]
Labels: Type-Cleanup Milestone-1.4

New issue 4315 by [hidden email]: #findElementOrNil: should be replaced  
by #scanFor: and deprecated
http://code.google.com/p/pharo/issues/detail?id=4315

subject


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4315 in pharo: #findElementOrNil: should be replaced by #scanFor: and deprecated

pharo

Comment #1 on issue 4315 by [hidden email]: #findElementOrNil:  
should be replaced by #scanFor: and deprecated
http://code.google.com/p/pharo/issues/detail?id=4315

when you mean that does it mean simply replacing?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4315 in pharo: #findElementOrNil: should be replaced by #scanFor: and deprecated

pharo

Comment #2 on issue 4315 by [hidden email]: #findElementOrNil:  
should be replaced by #scanFor: and deprecated
http://code.google.com/p/pharo/issues/detail?id=4315

we should pay attention to SystemTracer when we do that


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4315 in pharo: #findElementOrNil: should be replaced by #scanFor: and deprecated

pharo

Comment #3 on issue 4315 by [hidden email]: #findElementOrNil: should  
be replaced by #scanFor: and deprecated
http://code.google.com/p/pharo/issues/detail?id=4315

The behaviour of both methods is different. findElementOrNil: raises an  
error when a free slot is not found, while scanFor: returns 0.

I understand that this should never happen, but still I think it would be  
better to raise an error than returning 0.

Looking at the senders, no one seems to check the returned value, assuming  
that it will be different from 0.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4315 in pharo: #findElementOrNil: should be replaced by #scanFor: and deprecated

pharo

Comment #4 on issue 4315 by [hidden email]: #findElementOrNil: should be  
replaced by #scanFor: and deprecated
http://code.google.com/p/pharo/issues/detail?id=4315

There is no should, it will never fail to find a free slot.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4315 in pharo: #findElementOrNil: should be replaced by #scanFor: and deprecated

pharo
Updates:
        Labels: -Milestone-1.4

Comment #5 on issue 4315 by [hidden email]: #findElementOrNil:  
should be replaced by #scanFor: and deprecated
http://code.google.com/p/pharo/issues/detail?id=4315

not for 1.4....


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker