Issue 4316 in pharo: Deleting a directory from file list does not work

Status: Accepted
Owner: [hidden email]

New issue 4316 by [hidden email]: Deleting a directory from file  
list does not work
http://code.google.com/p/pharo/issues/detail?id=4316

Open file list and select "delete directory" on a temporary deletable  
directory in the left directory tree view.

=> DNU

SimpleHierarchicalListMorph(Object)>>doesNotUnderstand: #deleteDirectory
        Receiver: a SimpleHierarchicalListMorph(233570304)
        Arguments and temporary variables:
                aMessage: deleteDirectory
                exception: MessageNotUnderstood:  
SimpleHierarchicalListMorph>>deleteDirectory
                resumeValue: nil
        Receiver's instance variables:
                bounds: 74@137 corner: 349@293
                owner: a SystemWindow(351272960)
                submorphs: an Array(a ScrollBar(831782912) a TransformMorph(549715968))
                fullBounds: 74@137 corner: 349@293
                color: Color white
                extension: a MorphExtension (205258752) [locked]  [eventHandler = an  
EventHandl...etc...
                borderWidth: 1
                borderColor: (Color r: 0.745 g: 0.745 b: 0.745)
                model: a FileList
                slotName: nil
                open: false
                scrollBar: a ScrollBar(831782912)
                scroller: a TransformMorph(549715968)
                retractableScrollBar: false
                scrollBarOnLeft: false
                getMenuSelector: #volumeMenu:
                getMenuTitleSelector: nil
                hasFocus: false
                hScrollBar: a ScrollBar(252706816)
                selectedMorph: an IndentingListItemMorph(891289600)'package-cache'
                getListSelector: #initialDirectoryList
                keystrokeActionSelector: nil
                autoDeselect: false
                columns: nil
                sortingSelector: nil
                getSelectionSelector: #currentDirectorySelected
                setSelectionSelector: #setSelectedDirectoryTo:
                potentialDropMorph: nil
                lineColor: nil

FileList(Model)>>perform:orSendTo:
        Receiver: a FileList
        Arguments and temporary variables:
                selector: #deleteDirectory
                otherTarget: a SimpleHierarchicalListMorph(233570304)
        Receiver's instance variables:
               


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ReviewNeeded
        Cc: [hidden email] [hidden email]
        Labels: Milestone-1.3

Comment #1 on issue 4316 by [hidden email]: Deleting a directory  
from file list does not work
http://code.google.com/p/pharo/issues/detail?id=4316

- #deleteDirectory is in FileList, so this is not the problem

- FileList overrides perform:orSendTo: that delegates to super
-- in Pharo 1.2 there was a StringHolder>>perform:orSendTo: which is now  
removed
-- therefore Model>>perform:orSendTo: is now called for the super send
    and this directly delegates to the otherTarget (instead of a check for
    an implementation in self)

Adding #deleteDirectory to the list of messages in  
FileList>>perform:orSendTo:
fixes the problem for now - but it is still a mess!

Would make sense if someone implements a new Pharo file browser...



Attachments:
        FileList-performorSendTo.st  788 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4316 by [hidden email]: Deleting a directory  
from file list does not work
http://code.google.com/p/pharo/issues/detail?id=4316

oh yes!



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed

Comment #3 on issue 4316 by [hidden email]: Deleting a directory  
from file list does not work
http://code.google.com/p/pharo/issues/detail?id=4316

Yes ... more menues are broken. Click on "Add Server...", "Remove Server"  
and "Recent...." in the file tree for example - you also get a DNU.

So we have to add "recentDirs askServerInfo removeServer" to the selector  
list in FileList>>perform:orSendTo: too. Attached is the changeset that  
fixes all 4 menue items.

What a silly design the old File list has here... one has to add a selector  
for every new action feature! We should rework FileList in Pharo versions >  
1.3

At least the menu works for now.

Attachments:
        FixFileListMenues.1.cs  827 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4316 by [hidden email]: Deleting a directory  
from file list does not work
http://code.google.com/p/pharo/issues/detail?id=4316

Yes looks like an olllllllld ooooold ooold stuff from middle age.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #5 on issue 4316 by [hidden email]: Deleting a directory  
from file list does not work
http://code.google.com/p/pharo/issues/detail?id=4316

in 13233


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker