Issue 4331 in pharo: Lists Fusion

Status: FixProposed
Owner: [hidden email]
Labels: ToolsImprovement

New issue 4331 by [hidden email]: Lists Fusion
http://code.google.com/p/pharo/issues/detail?id=4331

Here is a cs which fusion List with single selection and list with multiple  
selection.

So now, you can only use the PluggableListMorph hierarchy, and you can  
switch between single and multiple selection on the fly.


For now, all methods are in the multi-selection protocol, since I'm waiting  
for feedback it's easier to retrieve methods :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 4331 by [hidden email]: Lists Fusion
http://code.google.com/p/pharo/issues/detail?id=4331

tx!!!!
Ben this is cool to see the system moving like that.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4331 by [hidden email]: Lists Fusion
http://code.google.com/p/pharo/issues/detail?id=4331

Oops :)

Attachments:
        ListsFusion.1.cs  22.4 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4331 by [hidden email]: Lists Fusion
http://code.google.com/p/pharo/issues/detail?id=4331

A new cs to migrate :)


With this cs, normally, references to ListsOfMany are removed :)

Attachments:
        RemoveListsOfMany.1.cs  3.5 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4331 by [hidden email]: Lists Fusion
http://code.google.com/p/pharo/issues/detail?id=4331

A new cs to distinguish between right click and cmd+click

Tested on Mac, should be tested on other OS

Attachments:
        PluggableListMorphFix.1.cs  1.1 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-1.4

Comment #5 on issue 4331 by [hidden email]: Lists Fusion
http://code.google.com/p/pharo/issues/detail?id=4331

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 4331 by [hidden email]: Lists Fusion
http://code.google.com/p/pharo/issues/detail?id=4331

I cannot apply listFusion because I have a duplicate warning.
After there are methods that got removed but they are not in my image  
beSimpleSelection isSimpleSelection.
So I do not know if I worked on the right version.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 4331 by [hidden email]: Lists Fusion
http://code.google.com/p/pharo/issues/detail?id=4331

So,

First apply CleanUp.1.cs, normally it's useless, but just to be sure.
Then apply ListsFusions.3.cs
Then RemoveListsOfMany.1.cs, PluggableListMorphFix.1.cs  and finally  
PostClean.1.cs to remove classes

Tested with the last 1.3 image, seems to work :)

Attachments:
        CleanUp.1.cs  511 bytes
        ListsFusion.3.cs  22.3 KB
        PostClean.1.cs  269 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 4331 by [hidden email]: Lists Fusion
http://code.google.com/p/pharo/issues/detail?id=4331

We will deprecate instead of remove the three classes :) but this is good  
to see that we can remove them :)

Smalltalk removeClassNamed: #PluggableIconListMorphOfMany!
Smalltalk removeClassNamed: #PluggableListMorphOfMany!
Smalltalk removeClassNamed: #PluggableMorphListMorphOfMany!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #9 on issue 4331 by [hidden email]: Lists Fusion
http://code.google.com/p/pharo/issues/detail?id=4331

in 13245


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 4331 by [hidden email]: Lists Fusion
http://code.google.com/p/pharo/issues/detail?id=4331

I dunno if you have missed to integrate RemoveListsOfMany.1.cs  or if I  
have posted a bad cs, but there is still references on  
PluggableListMorphOfMany in the last 1.3 Pharo core (#13246).


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 4331 by [hidden email]: Lists Fusion
http://code.google.com/p/pharo/issues/detail?id=4331

Yes this is normal I just deprecated them ie moved thm to the deprecated  
package.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker