Issue 4378 in pharo: Bad size of TasklistMorph preview with large titles

Status: New
Owner: ----

New issue 4378 by [hidden email]: Bad size of TasklistMorph preview  
with large titles
http://code.google.com/p/pharo/issues/detail?id=4378

Pharo image: dev
Pharo core version: Pharo1.3a Latest update: #13233
Virtual machine used: linux

Steps to reproduce:
1. open some window with large title (see attached screenshot)
2. open the Tasklist preview (cmd-left)

Attachments:
        Área de trabajo 1_002.png  135 KB

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 4378 by [hidden email]: Bad size of  
TasklistMorph preview with large titles
http://code.google.com/p/pharo/issues/detail?id=4378

I do not fix  it, but this patch is elegant :) (see screenshot)

Name:  
SLICE-Issue-4378-Bad-size-of-TasklistMorph-preview-with-large-titles-GastonDallOglio.1
Author: GastonDallOglio
Time: 8 June 2011, 9:17:29 pm
UUID: 6f229886-8cda-46c3-a6c8-822279c26568
Ancestors:
Dependencies: Polymorph-Widgets-GastonDallOglio.449,  
Settings-Polymorph-GastonDallOglio.31

Change the default size of preview.
Add a entry in Settings browser for choose size of preview, and validate  
this.


Attachments:
        Área de trabajo 1_005.png  155 KB

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4378 by [hidden email]: Bad size of  
TasklistMorph preview with large titles
http://code.google.com/p/pharo/issues/detail?id=4378

Perhaps the attached would be simpler, truncation of button label to 30  
chars.

Attachments:
        TasklistLabelTruncation.1.cs  1.0 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4378 by [hidden email]: Bad size of  
TasklistMorph preview with large titles
http://code.google.com/p/pharo/issues/detail?id=4378

I know, sure, but I don't like truncate it because as I don't see all chars  
I don't know distin between similar quickly. For other hand, I like choose  
the size of preview :) (where are the wish list for Pharo?)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4378 by [hidden email]: Bad size of  
TasklistMorph preview with large titles
http://code.google.com/p/pharo/issues/detail?id=4378

As I said, in the titles of windows, I think most often are more  
significant the final characters, so I suggest using # contract, instead of  
# truncate. i.e.:
'A clear but rather long-winded summary' contractTo: 18 => 'A  
clear ...summary'

Attachments:
        UITheme-newTasklistButtonInfor.st  1.0 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 4378 by [hidden email]: Bad size of  
TasklistMorph preview with large titles
http://code.google.com/p/pharo/issues/detail?id=4378

no interest in solving this little problem?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ReviewNeeded
        Cc: [hidden email]

Comment #6 on issue 4378 by [hidden email]: Bad size of  
TasklistMorph preview with large titles
http://code.google.com/p/pharo/issues/detail?id=4378

yes but for that we should see it and tag it as fixed


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-1.4

Comment #7 on issue 4378 by [hidden email]: Bad size of  
TasklistMorph preview with large titles
http://code.google.com/p/pharo/issues/detail?id=4378

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 4378 by [hidden email]: Bad size of  
TasklistMorph preview with large titles
http://code.google.com/p/pharo/issues/detail?id=4378

Good! Thanks.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed

Comment #9 on issue 4378 by [hidden email]: Bad size of TasklistMorph  
preview with large titles
http://code.google.com/p/pharo/issues/detail?id=4378

Thanks for reporting Gaston!
Maybe we don't need one more setting for that.
I've used contractTo: as you propose and changed the hResizing of the  
tasklistmorph from #rigid to #shrinkWrap. Finally made it always centered.  
It seems ok now.
in inbox:
SLICE-Issue-4378-Bad-size-of-TasklistMorph-preview-with-large-titles-AlainPlantec.1


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #10 on issue 4378 by [hidden email]: Bad size of  
TasklistMorph preview with large titles
http://code.google.com/p/pharo/issues/detail?id=4378

in 14160


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 4378 by [hidden email]: Bad size of  
TasklistMorph preview with large titles
http://code.google.com/p/pharo/issues/detail?id=4378


ok, cheers.
Really, I have took this bug for learn about add a entry in Settings  
browser, but I understand that is not needed include this for fix the  
problem (I will suggest later, along with other improvements).


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker